Give Gorreven its em dashes - #57
Merged
Merged
Conversation
Fourteen of them, all previously written as " - ", the cowardly dash that
looks least bad everywhere and right nowhere. Now that the wrapper keeps
"---" with the word in front of it, the real thing is safe to use.
Two of the fourteen sat at a fragment boundary, and the two kinds of
boundary do not behave alike:
- Consecutive ">>" lines are gathered into a paragraph with a space
between them, so a dash may not straddle that boundary -- it would
render as "sweaty--- and increasingly". The guard's uniform needed
its line rewrapped so that "sweaty---and" falls inside one line.
- Fragments of a single write are concatenated with nothing between
them, so a dash ends the first fragment and the next word opens the
second. The manila folder reads "folder and---no, I can't do this"
across that seam, and the wrapper may break there, which is the one
break inside a word that it allows.
Left alone: the stencilled lettering on two signs, "GORREVEN PAPERS - DO
NOT TOUCH" and "HIGH VOLTAGE - KEEP OFF", where the mark is painted on an
object rather than spoken by the narrator. Also the spaced hyphens in
comments, which never reach the wrapper, and the subtraction in debug.arch
and starship.arch, which is arithmetic.
" - " and "---" are both three characters, so no line changed length and
no line grew past the margin.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Ui8UMgev1U8LW5iyQdSsJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourteen dashes in
gorreven.arch, all previously written as-, convertedto
---. Both spellings are exactly three characters, so no line changedlength and none grew past the margin — the diff is 14 lines in, 14 out.
The two fragment boundaries do not behave alike
This is the part worth reviewing, and it was checked against the interpreter
rather than assumed:
>>lineswriteSo the guard's uniform needed rewrapping — as written,
sweaty---at the endof one
>>line would have renderedsweaty--- and increasingly:The manila folder needed no rewrapping, since
writefragments concatenate:"...folder and---", "no, I can't do this."renders asfolder and---no, andthe wrapper may break at that seam — the one break inside a word it allows.
At 36 columns the rewrapped passage breaks where it should, on the far side
of the mark:
Deliberately left alone
"GORREVEN PAPERS - DO NOT TOUCH"and"HIGH VOLTAGE - KEEP OFF"(gorreven_types.arch:381). The mark is paintedon an object, not spoken by the narrator; a stencil wouldn't use an em dash.
Say the word if you'd rather they matched.
--inutility.arch,intrptr.arch,starship_types.arch, andanimal.archis inside a#comment. Commentsnever reach the wrapper, so the libraries needed no changes at all.
starship.arch:836anddebug.arch:39.Compiles clean, smoke-tests clean. No
.acxis tracked undergames/, andneither pinned golden (
cherry,bare) involves Gorreven.🤖 Generated with Claude Code
https://claude.ai/code/session_013Ui8UMgev1U8LW5iyQdSsJ