Repository navigation
Reject build-only regression proof and save private local receipts - #7
Conversation
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
|
Merged after exact-head independent executed approval, zero unresolved obligations, green PR CI, and native forge observation at the final reviewed SHA before merge (2026-10-07 05:01:44). Manual merge used --match-head-commit and no administrator bypass; native auto-merge setting unchanged. Merged/source-installed revision: Installed Durable local release/rollback evidence: |
Assignment
Owner explicitly approved two improvements: (1) old-code compile/import-only failures are inconclusive, never behavioral proof; (2) automatic concise, private, durable local command receipts. Implementation seat: phobos (
test-check-proof-fix), receipt filesystem package contributed by independent workertest-check-receipts. No Gitmoot implementation jobs or provider/payment changes.Frozen final head:
888e88cd951507b433d2d476ca4b0e1def0a3e29; base main:b1a900dd502a4bd2f7d7ac7118bba9090da74802. Prior independent review at09c7708f7f1ba61f390b3d0bb5d9213075f1264erequested changes; both executed findings addressed and a fresh full final-head review is required.Changes
inconclusive/ exit 4 for old build/import failures, explicit reason and existing build flag; per-test aggregates and pieces cannot claim proof/guarded status for build-only failure. Actual Go/Python assertion summaries take precedence over diagnostic words in assertion messages. New-code failures remainfails_on_new.Exercised verification
Go 1.26.4; CGO=0, umask 022 for tests/vet/build/release. CGO=1 only for the required race detector.
GOTOOLCHAIN=go1.26.4 CGO_ENABLED=1 go test -race ./internal/receiptpassed.GOTOOLCHAIN=go1.26.4 CGO_ENABLED=0 go test ./...,go vet ./..., and actual CLI build passed.test-check proveproved seven consumer CLI regressions against original main, and four review-boundary regressions against reviewed head09c7708: actual old--- FAILtest results, all new pass,build_error_suspected=falseper test and aggregate. This does not claim all new package tests are old-compatible or old-red.Durable local evidence:
/root/fleet-tools/state/test-check-improvements-20261007/:proof/final-regression-proof.json(+ stderr)proof/advice.json(+ stderr)integration/final-built-cli/results.jsonintegration/evidence-index.json: copied/read-back private receipts + bounded details underintegration/durable-receipts/; not dependent solely on temporary fixture receipt paths.proof/review-fixed-original-base.jsonandproof/review-obligations-old-red.json.integration/review-fixed-cli/review-results.json.Independent formal final-head review, observed Gitmoot merge-gate prerequisites, and GitHub CI are required before merge. No administrator bypass.