Skip to content

prove --pieces: binary code files skipped; '#'/'--' comment heuristic drops JS lines #5

Open

Description

@jerryfane

P3 findings from review job local-review-review-router-18d8cada7e9bf07c-1 on PR #2 (head 06689688).

  1. A modified binary code file yields no hunks from git diff -U0, so it produces zero pieces and is silently untested. The outcome can still be proven. Fix: treat a changed file with no hunks as one whole-file piece.
  2. commentOnly treats # and -- as comment prefixes in every language. In JS/TS, #count = 0; (private fields) and --x are real code, so a hunk made only of those lines is dropped. Fix: choose comment prefixes by file extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions