You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
prove lock: stale lock on non-Unix and create-to-pid race #3
Review P3 findings from job local-review-review-router-18d8b041aad26ed9-1 on PR #1 (head 8c2204b4). Both fail safe; filed so they are not lost.
On non-Unix builds, processAlive always returns true. A lock left by a crashed run is never taken over, and the error does not say to delete .git/test-check-prove.lock.
acquire creates the lock with O_EXCL and writes the pid in a separate step. A concurrent run that reads the empty file in between treats it as stale. errStashTaken still prevents corruption, so the worst case is a spurious refusal. Fix: write the pid to a temp file and link it into place atomically.
Activity