You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(deploy): serve the event trigger on 127.0.0.1:8798 (#20) - #21
deploy/config.example.yaml: an events.secret_file section.
Deployment: create a 0600 /etc/stagehand/trigger.key, add events.secret_file to /etc/stagehand/config.yaml, install the unit, run daemon-reload, restart stagehand, and smoke-test with a signed curl. Roll back by removing the flag and restarting.
Decision:approved Summary: Reviewed the complete two-file diff from base d5b9056 to exact head 142b17f. No P0–P2 findings. The serve flag and events configuration keys match production code; the default payload limit is 67108864 bytes. Verified non-loopback addresses are rejected without --trigger-allow-remote and missing events.secret_file produces a clear startup failure. The unit has no other changes beyond the trigger flag and explanatory comment. Local static build, vet, tests, and isolated end-to-end smoke passed. Local CGO vet and race tests were blocked by sandbox denial of a compiler header; both passed in independently verified exact-head CI. No prior PR findings exist in the frozen verdict file or GitHub review records. No repository files were modified.
Tests Run
CGO_ENABLED=0 go build -trimpath -o "$TMPDIR/stagehand-review-pr21-142b17f" ./cmd/stagehand && "$TMPDIR/stagehand-review-pr21-142b17f" version -> passed; output: stagehand dev.
CGO_ENABLED=0 go vet ./... -> passed.
CGO_ENABLED=0 go test -count=1 ./... -> passed, including internal/cli, internal/engine, and internal/trigger.
go vet ./... -> blocked: runtime/cgo compilation denied access to /usr/include/stdc-predef.h.
go test -race -count=1 ./... -> blocked: runtime/cgo compilation denied access to /usr/include/stdc-predef.h.
CI-verified: go vet ./... -> success; run 42158422991 job 127698009432
CI-verified: go test -race -count=1 ./... -> success; run 42158422991 job 127698009432
Production-binary subprocess checks: stagehand serve --trigger-addr 127.0.0.1:8798 -> missing secret exited 1 with an explicit events.secret_file requirement; relative secret paths, negative payload limits, unknown configuration keys, and permissive secret-file permissions were rejected.
stagehand --config deploy/config.example.yaml status -> strict YAML decoding and validation passed; startup then stopped at the expected unprovisioned agent.sandboxd.api_key_file.
Isolated production smoke: stagehand serve --status-addr 127.0.0.1:40415 --trigger-addr 127.0.0.1:44241 -> status HTTP 200, unsigned trigger HTTP 401, signed event HTTP 202, duplicate HTTP 200, and stagehand runs smoke --json confirmed exactly one successful shell run. Listener reported the exact loopback address; SIGTERM exited 0.
Isolated HTTP payload-boundary smoke -> authenticated 67108864-byte request reached pipeline lookup; 67108865-byte request returned HTTP 413 with the correct limit.
Raw runtime output was retained in local Gitmoot state and is not posted here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20. Assignment: gitmoot msg 402990 (the-path, AI Reviewer), #18.
deploy/stagehand.service:serve --trigger-addr 127.0.0.1:8798(loopback only).deploy/config.example.yaml: anevents.secret_filesection.Deployment: create a 0600
/etc/stagehand/trigger.key, addevents.secret_fileto/etc/stagehand/config.yaml, install the unit, run daemon-reload, restartstagehand, and smoke-test with a signed curl. Roll back by removing the flag and restarting.