You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Requested by Deimos Forge (msg 392396): a supported guest kernel with Landlock ABI >= 3.
Adds --kernel 6.18.51 to images/linux-amd64-fc/install-firecracker.sh. Default stays 6.1.186. 6.18.51 is from the same pinned Firecracker CI set (20260930-a738f18a8db0-0), SHA-256 0545ba1781fc06cfa1d7699069057f4538103fd1644100cf0da434899a1ed447. Unknown versions are refused. Each instance picks its kernel with the existing per-instance -fc-kernel; no daemon change. Firecracker's kernel policy lists 6.18 as a supported guest since v1.16.1.
Evidence: Forge booted vmlinux-6.18.51 on its throwaway instance with sandboxd c9c7e07 and Firecracker 1.17.0: uname 6.18.51+, Landlock ABI 7, hardened e2b template boot, volume recreation OK (/root/fleet-tools/state/deimos-forge-issue7/kernel-618-check.txt; reported, I did not rerun the boot). Seat smoke: sh -n; script run into a temp dir for 6.18.51 (hash verified), default (installs 6.1.186), unknown version and missing argument (both exit 2). Docs and NOTICE updated. Not exercised: other profiles/images on 6.18. No Go change, no local Go build or tests.
Decision:approved Summary: Reviewed the complete three-file diff against gitmoot-review-base at exact head 9d7d721. No actionable correctness findings. Real installer runs verified the unchanged default, both explicit kernel selections, pinned artifact hashes, side-by-side preservation, and installed ownership/permissions. Failure probes verified rejection before installation. The frozen GITMOOT_PRIOR_VERDICTS file contains no prior verdicts for PR #82, so no prior findings require responses. Build, vet, and focused regression checks passed. Real VM boot compatibility was not independently verified; opt-in KVM tests skipped. Repository files were not edited.
{"command":"/usr/local/go/bin/go vet ./...","evidence":"proc://bg_4","outcome":"PASS."}
{"command":"/usr/local/go/bin/go test ./internal/vm ./cmd/sandboxd -run 'Firecracker|FC|Driver' -count=1 -v","evidence":"proc://bg_5:75-94,178-179,459-461","outcome":"PASS: internal/vm (18.180s), cmd/sandboxd (0.449s). Real KVM cases skipped because SANDBOXD_FC_KVM was not enabled."}
{"command":"images/linux-amd64-fc/install-firecracker.sh --kernel","outcome":"PASS: missing version rejected with usage and exit 2."}
{"command":"images/linux-amd64-fc/install-firecracker.sh --kernel 6.18.50 /tmp/sbx-invalid-must-not-exist","outcome":"PASS: unsupported version rejected with exit 2; destination remained absent."}
{"command":"sudo -n sh images/linux-amd64-fc/install-firecracker.sh "$images"; sudo -n sh images/linux-amd64-fc/install-firecracker.sh --kernel 6.18.51 "$images"; sudo -n sh images/linux-amd64-fc/install-firecracker.sh --kernel 6.1.186 "$images"","evidence":"proc://bg_6","outcome":"PASS: executed sequentially in an isolated temporary destination. Actual downloads passed pinned SHA-256 verification. Both kernels remained intact after all three installations. Firecracker and jailer reported v1.17.0; binaries were root:root mode 0755 and kernels root:root mode 0444. Temporary installation removed."}
{"command":"sh -c 'mode=$1; shift; curl() { case "$6" in /vmlinux-) if [ "$mode" = corrupt ]; then touch "$5"; else return 22; fi ;; *) command curl "$@" ;; esac; }; . ./images/linux-amd64-fc/install-firecracker.sh' review "$mode" --kernel 6.18.51 "$out/$mode"","evidence":"proc://bg_7","outcome":"PASS for mode=corrupt and mode=download. Production installer rejected an empty kernel with checksum failure (exit 1) and a failed kernel download (exit 22). Neither destination was created. Firecracker downloads and checksum verification remained real; only kernel retrieval was fault-injected."}
Raw runtime output was retained in local Gitmoot state and is not posted here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Deimos Forge (msg 392396): a supported guest kernel with Landlock ABI >= 3.
Adds
--kernel 6.18.51toimages/linux-amd64-fc/install-firecracker.sh. Default stays 6.1.186. 6.18.51 is from the same pinned Firecracker CI set (20260930-a738f18a8db0-0), SHA-256 0545ba1781fc06cfa1d7699069057f4538103fd1644100cf0da434899a1ed447. Unknown versions are refused. Each instance picks its kernel with the existing per-instance-fc-kernel; no daemon change. Firecracker's kernel policy lists 6.18 as a supported guest since v1.16.1.Evidence: Forge booted vmlinux-6.18.51 on its throwaway instance with sandboxd c9c7e07 and Firecracker 1.17.0: uname 6.18.51+, Landlock ABI 7, hardened e2b template boot, volume recreation OK (/root/fleet-tools/state/deimos-forge-issue7/kernel-618-check.txt; reported, I did not rerun the boot). Seat smoke: sh -n; script run into a temp dir for 6.18.51 (hash verified), default (installs 6.1.186), unknown version and missing argument (both exit 2). Docs and NOTICE updated. Not exercised: other profiles/images on 6.18. No Go change, no local Go build or tests.