Repository navigation
Add scoped renewable guest TCP tunnels for SSH adapters - #79
Conversation
|
Review status at head 446ac83: level3_required. Implementer attribution saved as session-implement-sandboxd-18e393c543132728 (sandboxd seat). g7-review independent review-only dispatch was refused before creating a job: Janitor disk-pressure admission_hold on /root/.gitmoot, cleanup_needed. Escalated to Jarvis; no bypass or merge. Actual Forge Firecracker/HerdrUp acceptance remains pending reviewed pin. All five new tests proven red on old/green on new; race run passed. |
|
Canonical independent review requested at exact 446ac83: job local-review-review-router-18e3a7ab4a909cce-1. Remote execution backend, read-only, no automatic fix target; sandboxd owns findings. Reviewer g7-review is independent of implementation but uses the same model family. Current observed state: queued, not yet evidence of remote execution or approval. No local build or merge; existing CI remains passing. |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
|
Addressing P2 from review local-review-review-router-18e3a7ab4a909cce-1 at new head1920aa086904bca8cda1eae836bc477b4caee94d. Framed EOF now reports directional completion while its existing copy goroutine continues observing raw transport closure; cancellation closes both endpoints and joins both copies. Added real worker-upgrade/TCP and guest-agent socket regressions plus both-direction framed bridge coverage preserving reverse traffic. Documentation updated. Local execution prohibited by source-host disk hold; no local builds/tests/go-run, only standalone gofmt. Same reviewer remote re-review local-review-review-router-18e3a8d9c2494785-1 queued, baseline446ac832; independent runtime smoke and new-tests red/green requested in PR description. Verification pending, not claiming the correction passes yet. |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
|
Correction to evidence-metadata diagnosis: Gitmoot established issue gitmoot/gitmoot#2465 from the actual clamp event. The earlier1920aa0 review was downgraded because its tests_run honestly recorded initial PATH exit127 failures, despite subsequent successful absolute-path build/vet/tests/race/runtime smoke. This is NOT a string-versus-object schema issue. Raw verdict and failed attempts are preserved; no evidence rewrite or gate bypass. Final integrated headc9c7e0709b538bac9c185a8269c8ce4c7cc92608 has its own canonical review pending; old verdict is not treated as exact-head approval. |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
|
Final exact-head independent review APPROVED at c9c7e07: job local-review-review-router-18e3aa764d1296db-1, g7-review, normalized evidence=executed. Prior P2 #79-f1 explicitly answered; no new defects. Reviewer executed Go1.26.4 build/vet, all five affected packages with race detection, focused storage/claim regressions, and tunnel lifecycle regressions20 times under race detection. Independent in-memory production-controller HTTP smoke passed64MiB integrity/restore/auth/input/capacity/cleanup scenarios. Failed initial PATH attempts and successful absolute-path retries are retained honestly. Job event omp_provider_verified reports actual openai-codex; reviewer independent from implementation, same family disclosed. No live-service actions or source edits by reviewer. Root-only foreign-owner repair branch skipped under non-root execution. Both exact-head CI jobs pass and L3 classification rerun; merging with exact-head guard under existing assignment. New permanent tests isolated old-code/test-check proof remains unverified; independent runtime probes failed at old446ac832 and passed correction1920aa0, and final-head regressions pass. Historical evidence-clamp issue2465 is not rewritten or used as current approval. No shared deployment, Forge guest acceptance or credential-reset/release claim. |
Closes #78.
Assignment: Jarvis376089; Forge #4 integration/acceptance belongs to deimos-forge. Contract accepted in 376122/376124. Implementer: sandboxd seat (in-session), not a review job.
Change
Verification
go test -p 2 ./...: all packages passed.test-check prove --test "env GOTOOLCHAIN=go1.26.10 GOMAXPROCS=2 go test -p 2 ./internal/control ./internal/guestagent -v -run '^{name}$'": all four new tests PROVEN, red on old code and green on new. Receipt: /root/.local/state/test-check/receipts/20261031T093520Z-5e306e7ed76c9f1bc7ec38d940c26402/receipt.json.Deployment and acceptance boundary
No shared daemon, listener, credentials, firewall, Phobos or Mac changes. Forge must rebuild its own image with matching guest agent and pin reviewed source before product acceptance. Actual Firecracker and HerdrUp/Citadel SSH acceptance are not yet verified. Memory-only lease rollback is fail-closed: restart invalidates leases, Forge remints. Old binaries do not offer the new CONNECT API.
Final expanded proof: all FIVE tests proven, including remote worker directional
EOF. Command added
./internal/workerto the proof package list.Receipt: /root/.local/state/test-check/receipts/20261031T093823Z-ef1e2d8746c17126b6a4e53069902b8a/receipt.json.
Race check:
go test -p 2 -race ./internal/control ./internal/guestagent ./internal/worker -run TestTunnel -count=1 -vpassed all five tests.Independent review correction: cancellation after directional EOF
Review job
local-review-review-router-18e3a7ab4a909cce-1requested changesat
446ac8326b18a521a1c7cd9795168313c0150350: after a framed EOF,the bridge stopped reading that transport. A later transport close left an
idle reverse copy and its downstream connection alive. The reviewer reproduced
this both directly and through the actual worker HTTP upgrade; the earlier
passing tests did not exercise this sequence.
The bridge now reports directional EOF, continues observing its framed source
for closure or illegal post-EOF bytes, and closes both connections and joins
both copy goroutines on cancellation or completion. No extra reader goroutine,
unbounded buffer, timeout workaround or protocol change.
Added direct bidirectional bridge coverage, an actual worker upgrade/TCP guest
regression, and a guest-agent accepted-socket disconnect case. They keep the
opposite peer open and idle, so cleanup cannot pass because the guest closes.
The direct regression also verifies reverse traffic still works after EOF.
Existing operator documentation now states this lifecycle guarantee explicitly.
At correction head
1920aa086904bca8cda1eae836bc477b4caee94d, independentreview job
local-review-review-router-18e3a8d9c2494785-1approved and markedthe prior P2 answered. Reviewer executed build, focused vet, four affected
package suites, all tunnel regressions 20 times under race detection, and a
memory-only production-Bridge smoke (transport close, illegal post-EOF data,
both directional EOFs, reverse payload preservation): all passed. Initial
PATH-based attempts failed because Go was absent from PATH; absolute-path
commands succeeded. These are reviewer executions, not local reruns.
The raw verdict declares
evidence=executed, but Gitmoot normalized it tostatic_only; this discrepancy is escalated in message377713, not overridden.CI did not run on1920aa0 because merging PR81 into main introduced one service
field conflict. Integrated reviewed main at
c9c7e0709b538bac9c185a8269c8ce4c7cc92608,retaining both tunnel leases and volume transfer slots. Final integrated-head
CI and independent review remain required.
Source-host build/test/go-run remains prohibited by the disk hold. The original
review supplies failing-before runtime evidence and the correction review
supplies passing-after evidence. New permanent tests are green, but their
own isolated red-on-old proof/test-check run is still unverified.
Remote reviewer: if feasible, use a memory-only Go overlay replacing ONLY
internal/tunnel/stream.gowith its446ac832version to establish red/greenfor
TestBridgeTransportCloseAfterDirectionalEOF,TestTunnelRemoteCloseAfterDirectionalEOFandTestTunnelDirectionalEOF/host-disconnectwithout editing repository files.