Repository navigation
Service edit form: a checkbox for forward_role (156) - #157
Conversation
Turning forward_role on needed pasted settings, which replace every field the paste names or omits. The edit form now has 'Tell the service which agent is calling'; the form owns it like its other fields (ticked keeps or sets it, unticked clears it); pasted settings still set it.
|
test-check prove: TestForwardRoleSetByPasteOrCheckbox proven (red on old). TestServiceProjectFromTheDashboard not_red_on_old: untouched test, listed only because it shares the edited file. |
Decision: Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
Closes 156. Follow-up to #151: to turn on
forward_rolefor macserve-builds the owner had to paste settings, and the paste box starts empty, so every other setting (base, project, test path, fixed headers) had to be retyped or was lost.Change
forward_rolewhen it changes.Behaviour change vs #151: a form submit without the box now clears forward_role (normal checkbox semantics; the form renders it ticked when on, so a browser edit keeps it).
TestForwardRoleSetByPasteKeptByFormEditasserted the old "form edit keeps it without the field" rule; renamedTestForwardRoleSetByPasteOrCheckboxand updated to: page shows it ticked; ticked keeps; unticked clears; ticking sets.Evidence