Repository navigation
OAuth failures show the provider's description to the owner; Show value flags invisible characters (144) - #145
Conversation
…ue flags invisible characters (144) Google answers invalid_client both for an unknown client and a wrong secret and tells them apart only in error_description, which the keyring dropped. It is now kept apart from the error text: plain ASCII, at most 160 bytes, and dropped if it echoes the refresh token, secret or client ID. It shows in the owner's failing status on the key page, never in agents' 503 bodies or the audit. Show value warns when a single-line value holds a non-ASCII (often invisible) character, naming its code point and position, or is wrapped in quotes.
|
test-check prove: TestShowValueFlagsInvisibleCharactersAndQuotes proven; TestOAuthFailureDescriptionForTheOwnerOnly inconclusive only because it also calls the new oauthDescription. Manual old-code run (old oauth2.go + a shim oauthDescription returning ""): it fails with owner status lacking |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
Decision: Findings
Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
Closes 144. For Jarvis 447488: the Gmail service still gets
invalid_clientalthough the owner checked the client ID and secret. Google uses that code both for "The OAuth client was not found." and for "Unauthorized" (wrong secret), and onlyerror_descriptiontells them apart. The keyring dropped it.Change
provider said: "…". The description is kept apart from the error, so agents' 503 bodies and the audit are unchanged (the existing test asserting that still passes). It is dropped if it contains the refresh token, secret or client ID, or anything but printable ASCII, and is cut at 160 bytes.Evidence
TestOAuthFailureDescriptionForTheOwnerOnly: invalid_client plus "Unauthorized" appears in the owner status and not in the agent's 503; descriptions that echo a secret, contain a line break or are non-ASCII are dropped.TestShowValueFlagsInvisibleCharactersAndQuotes: a zero-width space is reported as U+200B at character 11, quotes are flagged, a clean value gets no warning.