Skip to content

feat!: rename dashboard vocabulary: reviewers, PRs, runs, campaigns (gitmoot/gitmoot#2603) - #143

Merged
jerryfane merged 3 commits into
mainfrom
intern/2603-rename
Nov 14, 2026
Merged

jerryfane merged 3 commits into
mainfrom
intern/2603-rename

Conversation

@jerryfane

Copy link
Copy Markdown
Collaborator

Part of gitmoot/gitmoot#2603 (rename epic gitmoot/gitmoot#2596; assignment: owner 2026-11-14 via gitmoot, seat gitmoot-intern). Policy gitmoot/gitmoot#2598: dashboard routes and payload fields switch in one release with their consumers (this frontend and gitmoot's server); no dual names. Glossary: agent → reviewer, task → pr, job → run, workflow → campaign.

Collisions renamed first

  • Root-tree fields: run→root, runId→rootId, runs→roots, nextRunCursor→nextRootCursor, ?runCursor→?rootCursor, ?maxRuns→?maxRoots.
  • Label suffix: campaign→name.

Routes

API /api/jobs→/api/runs, /api/job/{id}→/api/run/{id}, /api/job/{id}/checks→/api/run/{id}/checks, /api/agents→/api/reviewers, /api/agent/{name}→/api/reviewer/{name}, /api/tasks→/api/prs, /api/workflows→/api/campaigns, /api/workflow/{label}→/api/campaign/{label}. Pages /runs, /reviewers[/<name>], /prs, /campaigns[/<label>]; ?reviewer=, comms ?campaign=. The frontend router rewrites the old page paths (/jobs, /agents, /tasks, /workflows, ?agent=, ?workflow=) to the new ones so bookmarks keep working. Old API routes 404 (the gitmoot server keeps /api/workflows as a hidden one-release alias for the fleet's status probes).

Payload fields

agent→reviewer; agents→reviewers; activeAgents→activeReviewers; jobCount→runCount; jobs→runs; jobs_today→runs_today; active_jobs→active_runs; jobId→runId; workflows→campaigns; wf→campaign; needs-you kinds stalled_campaign/blocked_run/unlabeled_runs; Galaxy node/link types run/reviewer/campaign; error texts. Kept: ConfigSnapshot.agents and jobTimeout (mirror config keys that stay), stored run type values review/ask/implement, internal ids/CSS/data attributes and Go type names.

Labels

Navigation, mobile tabs, page titles, headers, placeholders, empty/error states, Galaxy legend and tooltips, Config ("Per-reviewer overrides", "Reviewer"), charts, health, comms. The Runs page gains a Kind filter (review / ask / implement). Runs without a reviewer (implementation records) show -.

Verification

  • gofmt, build, vet, go test ./...: pass; inline script passes node --check.
  • With the matching gitmoot server branch on a copy of the live DB: every page loads with 0 responses ≥ 400 and 0 page errors; old page paths redirect; old API routes 404 except /api/workflows (200, same body). Screenshots: /root/fleet-tools/state/gitmoot-scope-reduction/rename/dash-2603/.
  • Acceptance grep on visible text: remaining hits are JS identifiers, CSS classes, data attributes and redirect comments only.

Merge order

This PR first; the gitmoot server PR pins the merged commit and ships in the rename release.

@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e7e6eab888d90e-1

Decision: changes_requested
Summary: Reviewed the full diff from d0b784c to 63457ad. Local build, vet, race tests, API checks, and WebKit UI scenarios completed. One reproduced regression: Galaxy normalization drops fields consumed by the renamed tooltips. Redirects, removed API routes, Kind filtering, campaign pagination, and retained configuration fields passed. The frozen prior-verdicts file contains no entries for PR #143. No separate introduced P3 design issue found. Operator screenshots were permission-denied; captured independent browser evidence instead.
Severity: P2

Findings

  • Preserve the renamed fields when cloning Galaxy nodes (P2)
    • body: renderGalaxy() copies API reviewer/root/runCount into obsolete agent/run/jobCount properties. The updated tooltip reads n.reviewer and n.runCount at lines 1511–1516, so valid responses silently render a blank reviewer and zero campaign runs. Reproduced locally: the campaign API supplies runCount=7, but hovering fable/dashboard-redesign shows 'runs 0'; a run tooltip has an empty reviewer despite project-lead being present in the API response. Keep one canonical graph-node shape and migrate the remaining _galaxyAgentName() and _galaxySignature() consumers together.
    • evidence_locator: web/dist/index.html:1922 and 1511–1516 at 63457ad; executed graph.nodeLabel() on live normalized nodes; campaign-hover screenshot /tmp/omp-sshots-15cdc70a879bd912.webp
    • file: web/dist/index.html
    • line: 1922

Tests Run

  • PATH=/usr/local/go/bin:$PATH go build ./... -> PASS
  • PATH=/usr/local/go/bin:$PATH go vet ./... -> PASS
  • PATH=/usr/local/go/bin:$PATH go test -race ./... -> PASS; dashboard package ok, development command has no test files
  • PATH=/usr/local/go/bin:$PATH go run ./cmd/gitmoot-dashboard-dev -addr 127.0.0.1:8099 -> local server started successfully; stopped after review
  • node (stdin assert/strict HTTP contract script) -> PASS: all eight removed API routes returned 404; renamed list/detail fields, encoded campaign labels, rootCursor pagination, overview/charts/attention/graph contracts, ConfigSnapshot.agents and jobTimeout verified
  • WebKit page.goto()/waitForSelector() assertions -> PASS: /tasks, /jobs?agent=implementer, /agents, /agents/researcher, /workflows and /workflows/fable%2Fdashboard-redesign canonicalized and rendered
  • WebKit select('#jb-kind', ask|implement|review) -> each selection matched exact expected run IDs; Reviewer facet, Clear and run-detail fetch also verified
  • WebKit click('#wf-load-earlier') -> PASS: exhausted campaign history with 16 unique roots and 33 unique notes
  • WebKit cross-page scenarios -> PASS: reviewer jobTimeout displayed as 30m; chart totals.runs=37 and reviewer rows rendered; ConfigSnapshot.agents table, attention failed-check expansion, health reviewer labels and Org campaign links rendered
  • WebKit Galaxy hover and graph.nodeLabel()(node) -> FAIL: campaign tooltip displays runs 0 instead of 7 and run tooltip reviewer is blank; reviewer/campaign legend labels render correctly

Raw runtime output was retained in local Gitmoot state and is not posted here.

The tooltip reads reviewer/runCount but renderGalaxy still copied them
into agent/jobCount, so run tooltips showed no reviewer and campaign hubs
showed 0 runs. Clone reviewer/root/runCount as-is and update the
signature and hub-name readers. Node ids keep the stored agent:: prefix.
@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e7e7b9aecedbaa-1

Decision: approved
Summary: Reviewed only 63457ad..377a9e4, with necessary surrounding consumers. The prior P2 is resolved: Galaxy preserves reviewer/root/runCount, campaign polling detects runCount changes, and reviewer lookup retains stored agent:: identifiers. No remaining Galaxy consumers of obsolete node fields or new correctness/design defects found in this delta. Local build, vet, tests, focused production-method checks, and browser verification passed. No repository files changed.

Findings

  • Resolved: preserve the renamed fields when cloning Galaxy nodes (P2)
    • continues_uid: feat!: rename dashboard vocabulary: reviewers, PRs, runs, campaigns (gitmoot/gitmoot#2603) #143-f1
    • detail: Checked at the exact requested head. Executed production Component methods to verify canonical clone fields, reviewer-name precedence and agent:: fallback, rollup-only polling updates including transition to zero, and layout preservation. In the real WebKit dashboard, the campaign tooltip displayed runs 7, the run tooltip displayed reviewer project-lead, and clicking the stored agent::project-lead hub loaded its reviewer profile. No unresolved concern remains.
    • evidence_locator: web/dist/index.html:1922,2029,2121 at 377a9e4; executed Node VM harness and live graph.nodeLabel() checks; campaign-hover screenshot /tmp/omp-sshots-15cdcb36d9573da7.png
    • file: web/dist/index.html
    • line: 1922
    • state: answered

Tests Run

  • export PATH=/usr/local/go/bin:$PATH; go build ./... && go vet ./... && go test ./... -> success; dashboard package tests passed, development command has no test files.
  • node <<'NODE' [inline harness evaluating the unchanged production Component from web/dist/index.html] -> PASS: canonical cloned fields, clone isolation, reviewer precedence and stored-ID fallback, unchanged-poll suppression, runCount-only updates including zero, preserved positions, resolved-link signature equivalence, and empty payloads.
  • export PATH=/usr/local/go/bin:$PATH; go run ./cmd/gitmoot-dashboard-dev -addr 127.0.0.1:8099 -> local fake-feed dashboard started successfully; stopped after review.
  • WebKit browser at http://127.0.0.1:8099/galaxy -> verified live normalized reviewer/root/runCount fields, campaign hover showing runs 7, run hover showing reviewer project-lead, and reviewer-hub click loading the project-lead profile; no browser JavaScript errors.
    Diagnostics: workflow advance failed: workflow blocked: local worktree is not clean

Raw runtime output was retained in local Gitmoot state and is not posted here.

@jerryfane
jerryfane merged commit cf68cc4 into main Nov 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant