Repository navigation
feat!: drop pipelines and keychain grants from the DataSource contract (gitmoot/gitmoot#2542) - #140
Conversation
gitmoot/gitmoot#2542) gitmoot is removing its pipelines feature entirely (users moved to gitmoot/stagehand) and, with it, keychain grants (`key grant/revoke`, the keychain_grants table). This removes both from the dashboard contract so the gitmoot side can delete its implementations instead of stubbing them. Removed from the DataSource interface: Pipelines(ctx) ([]PipelineSummary, error) PipelineRun(ctx, id) (PipelineRun, error) PipelineDetail(ctx, name) (PipelineDetail, error) Removed payload types: PipelineSummary, PipelineRunSummary, PipelineRun, PipelineStage, PipelineStageMark, PipelineRunHistoryEntry, PipelineDetail, PipelineKeys, PipelineEnvFileStatus, PipelineStageKeys, PipelineKeyEntry, OverviewScheduled, KeychainGrantView; sentinels ErrPipelineRunNotFound and ErrPipelineNotFound. Removed fields: Overview.Scheduled (the "scheduled" overview panel listed declared pipelines only) and KeychainKeyView.Grants (every grant consumer was a pipeline; grants are gone in gitmoot). Routes removed: GET /api/pipelines, /api/pipelines/{name}, /api/pipeline/run/{id}. web/dist/index.html (hand-maintained, no build step in this repo): removed the Pipelines nav entry and its attention dot, the mobile more-sheet entry, the Pipelines page (list, detail workbench, stage DAG, run history, keys tab) with its CSS, polling and fetches, the /pipelines and /pipelines/<name> routes (now normalized to Overview), the Activepieces top-bar link ("the flow builder that drives gitmoot pipelines"), the Overview scheduled-pipelines panel, and the Config keychain Grants column/search terms. fakefeed.go: dropped fakePipelineRuns, fakePipelineRunSummary, fakePipelines, fakePipelineHistoryEntry, fakePipelineDetail, the Overview scheduled fixture and keychain grant fixtures; renamed the pipeline-namespaced workflow/wake fixture values to non-pipeline ones. Tests whose subject was a removed surface are deleted (TestHandlePipelines*, TestHandlePipelineRun*, TestHandlePipelineDetail*, TestPipelineStageProgressJSON, TestPipelinesRouteRegistered); surviving overview/keychain tests keep their other assertions. Gate: go build ./... && go vet ./... && go test ./... pass; gofmt clean.
Decision: Tests Run
Raw runtime output was retained in local Gitmoot state and is not posted here. |
feat!: drop pipelines and keychain grants from the DataSource contract (gitmoot/gitmoot#2542)
gitmoot is removing its pipelines feature entirely (users moved to
gitmoot/stagehand) and, with it, keychain grants (
key grant/revoke, thekeychain_grants table). This removes both from the dashboard contract so the
gitmoot side can delete its implementations instead of stubbing them.
Removed from the DataSource interface:
Pipelines(ctx) ([]PipelineSummary, error)
PipelineRun(ctx, id) (PipelineRun, error)
PipelineDetail(ctx, name) (PipelineDetail, error)
Removed payload types: PipelineSummary, PipelineRunSummary, PipelineRun,
PipelineStage, PipelineStageMark, PipelineRunHistoryEntry, PipelineDetail,
PipelineKeys, PipelineEnvFileStatus, PipelineStageKeys, PipelineKeyEntry,
OverviewScheduled, KeychainGrantView; sentinels ErrPipelineRunNotFound and
ErrPipelineNotFound.
Removed fields: Overview.Scheduled (the "scheduled" overview panel listed
declared pipelines only) and KeychainKeyView.Grants (every grant consumer was a
pipeline; grants are gone in gitmoot).
Routes removed: GET /api/pipelines, /api/pipelines/{name},
/api/pipeline/run/{id}.
web/dist/index.html (hand-maintained, no build step in this repo): removed the
Pipelines nav entry and its attention dot, the mobile more-sheet entry, the
Pipelines page (list, detail workbench, stage DAG, run history, keys tab) with
its CSS, polling and fetches, the /pipelines and /pipelines/ routes (now
normalized to Overview), the Activepieces top-bar link ("the flow builder that
drives gitmoot pipelines"), the Overview scheduled-pipelines panel, and the
Config keychain Grants column/search terms.
fakefeed.go: dropped fakePipelineRuns, fakePipelineRunSummary, fakePipelines,
fakePipelineHistoryEntry, fakePipelineDetail, the Overview scheduled fixture
and keychain grant fixtures; renamed the pipeline-namespaced workflow/wake
fixture values to non-pipeline ones. Tests whose subject was a removed surface
are deleted (TestHandlePipelines*, TestHandlePipelineRun*,
TestHandlePipelineDetail*, TestPipelineStageProgressJSON,
TestPipelinesRouteRegistered); surviving overview/keychain tests keep their
other assertions.
Gate: go build ./... && go vet ./... && go test ./... pass; gofmt clean.