Skip to content

feat!: drop pipelines and keychain grants from the DataSource contract (gitmoot/gitmoot#2542) - #140

Merged
jerryfane merged 1 commit into
mainfrom
chore/drop-pipelines-2542
Nov 7, 2026
Merged

jerryfane merged 1 commit into
mainfrom
chore/drop-pipelines-2542

Conversation

@jerryfane

Copy link
Copy Markdown
Collaborator

feat!: drop pipelines and keychain grants from the DataSource contract (gitmoot/gitmoot#2542)

gitmoot is removing its pipelines feature entirely (users moved to
gitmoot/stagehand) and, with it, keychain grants (key grant/revoke, the
keychain_grants table). This removes both from the dashboard contract so the
gitmoot side can delete its implementations instead of stubbing them.

Removed from the DataSource interface:
Pipelines(ctx) ([]PipelineSummary, error)
PipelineRun(ctx, id) (PipelineRun, error)
PipelineDetail(ctx, name) (PipelineDetail, error)
Removed payload types: PipelineSummary, PipelineRunSummary, PipelineRun,
PipelineStage, PipelineStageMark, PipelineRunHistoryEntry, PipelineDetail,
PipelineKeys, PipelineEnvFileStatus, PipelineStageKeys, PipelineKeyEntry,
OverviewScheduled, KeychainGrantView; sentinels ErrPipelineRunNotFound and
ErrPipelineNotFound.
Removed fields: Overview.Scheduled (the "scheduled" overview panel listed
declared pipelines only) and KeychainKeyView.Grants (every grant consumer was a
pipeline; grants are gone in gitmoot).
Routes removed: GET /api/pipelines, /api/pipelines/{name},
/api/pipeline/run/{id}.

web/dist/index.html (hand-maintained, no build step in this repo): removed the
Pipelines nav entry and its attention dot, the mobile more-sheet entry, the
Pipelines page (list, detail workbench, stage DAG, run history, keys tab) with
its CSS, polling and fetches, the /pipelines and /pipelines/ routes (now
normalized to Overview), the Activepieces top-bar link ("the flow builder that
drives gitmoot pipelines"), the Overview scheduled-pipelines panel, and the
Config keychain Grants column/search terms.

fakefeed.go: dropped fakePipelineRuns, fakePipelineRunSummary, fakePipelines,
fakePipelineHistoryEntry, fakePipelineDetail, the Overview scheduled fixture
and keychain grant fixtures; renamed the pipeline-namespaced workflow/wake
fixture values to non-pipeline ones. Tests whose subject was a removed surface
are deleted (TestHandlePipelines*, TestHandlePipelineRun*,
TestHandlePipelineDetail*, TestPipelineStageProgressJSON,
TestPipelinesRouteRegistered); surviving overview/keychain tests keep their
other assertions.

Gate: go build ./... && go vet ./... && go test ./... pass; gofmt clean.

gitmoot/gitmoot#2542)

gitmoot is removing its pipelines feature entirely (users moved to
gitmoot/stagehand) and, with it, keychain grants (`key grant/revoke`, the
keychain_grants table). This removes both from the dashboard contract so the
gitmoot side can delete its implementations instead of stubbing them.

Removed from the DataSource interface:
  Pipelines(ctx) ([]PipelineSummary, error)
  PipelineRun(ctx, id) (PipelineRun, error)
  PipelineDetail(ctx, name) (PipelineDetail, error)
Removed payload types: PipelineSummary, PipelineRunSummary, PipelineRun,
PipelineStage, PipelineStageMark, PipelineRunHistoryEntry, PipelineDetail,
PipelineKeys, PipelineEnvFileStatus, PipelineStageKeys, PipelineKeyEntry,
OverviewScheduled, KeychainGrantView; sentinels ErrPipelineRunNotFound and
ErrPipelineNotFound.
Removed fields: Overview.Scheduled (the "scheduled" overview panel listed
declared pipelines only) and KeychainKeyView.Grants (every grant consumer was a
pipeline; grants are gone in gitmoot).
Routes removed: GET /api/pipelines, /api/pipelines/{name},
/api/pipeline/run/{id}.

web/dist/index.html (hand-maintained, no build step in this repo): removed the
Pipelines nav entry and its attention dot, the mobile more-sheet entry, the
Pipelines page (list, detail workbench, stage DAG, run history, keys tab) with
its CSS, polling and fetches, the /pipelines and /pipelines/<name> routes (now
normalized to Overview), the Activepieces top-bar link ("the flow builder that
drives gitmoot pipelines"), the Overview scheduled-pipelines panel, and the
Config keychain Grants column/search terms.

fakefeed.go: dropped fakePipelineRuns, fakePipelineRunSummary, fakePipelines,
fakePipelineHistoryEntry, fakePipelineDetail, the Overview scheduled fixture
and keychain grant fixtures; renamed the pipeline-namespaced workflow/wake
fixture values to non-pipeline ones. Tests whose subject was a removed surface
are deleted (TestHandlePipelines*, TestHandlePipelineRun*,
TestHandlePipelineDetail*, TestPipelineStageProgressJSON,
TestPipelinesRouteRegistered); surviving overview/keychain tests keep their
other assertions.

Gate: go build ./... && go vet ./... && go test ./... pass; gofmt clean.
@jerryfane
jerryfane merged commit df87a23 into main Nov 7, 2026
2 checks passed
@jerryfane

Copy link
Copy Markdown
Collaborator Author

Agent: gm-review-grok
Runtime: omp
Job: local-review-review-router-18e59f0d8fa9d1d1-1

Decision: approved
Summary: Reviewed the full diff from base 418f627 to exact head f433424. No actionable regressions found. Removed pipeline methods, payloads, routes, polling, navigation, and keychain grants have no remaining functional references; remaining contract changes are limited to the intended Overview.Scheduled and KeychainKeyView.Grants removals. Build, vet, full tests, focused contract tests, and live HTTP/browser checks passed. Desktop navigation remains functional, mobile More omits Pipelines, and retired frontend deep links normalize to Overview. No prior findings for PR #140 were recorded in the frozen prior-verdicts file. No repository files changed.

Tests Run

  • env PATH=/usr/local/go/bin:/usr/local/bin:/usr/bin:/bin sh -c 'go version && go build ./... && go vet ./... && go test -count=1 ./...' -> success with go1.26.4 linux/amd64; build, vet, and all tests passed.
  • env PATH=/usr/local/go/bin:/usr/local/bin:/usr/bin:/bin go test -count=1 -v -run 'Test(FakeOverviewContractOrderingAndDeterminism|HandleOverviewAndTasksUnsupportedDataSource|HandleConfig.*|FakeWorkflowIndexContractOrderingAndDeterminism|HandleWorkflowNotFound|HandleWorkflowSlashLabelRoundTrip|FakeWakeLedgerContractFiltersAndDeterminism|StateRouteRegistered|OrgRoutesRegistered)$' ./... -> success; all selected tests and subtests passed.
  • env PATH=/usr/local/go/bin:/usr/local/bin:/usr/bin:/bin go run ./cmd/gitmoot-dashboard-dev -addr 127.0.0.1:18099 -> server started successfully. Python urllib.request live checks passed for overview/config JSON field sets, surviving API endpoints, embedded assets, and all three removed API routes falling through to the existing HTML SPA fallback.
  • Chromium browser.open/tab.run smoke against the local server -> all 12 desktop navigation destinations opened their corresponding visible views; Overview rendered without Scheduled; Config rendered four keys with Name, Mode, Upstream / Auth, and Created columns; filtering for openai retained the correct proxied key.
  • Chromium desktop/mobile smoke -> /pipelines and /pipelines/nightly-deploy normalized to / and rendered Overview; 390x844 mobile More contained no Pipelines entry and opened Config successfully; observed requests included zero retired pipeline API requests; no browser JavaScript errors observed. Screenshots inspected.

Raw runtime output was retained in local Gitmoot state and is not posted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant