Jev 3: add decision records and shared draft primitives - #255
Merged
Merged
Conversation
MaggieAppleton
added this pull request to stack #254
October 3, 2026 06:16
MaggieAppleton
changed the title
MaggieAppleton
marked this pull request as ready for review
October 3, 2026 08:09
MaggieAppleton
force-pushed
the
maggie/jev-decision-records
branch
2 times, most recently
from
October 3, 2026 11:12
dafa13f to
7605c2f
Compare
MaggieAppleton
force-pushed
the
maggie/jev-decision-records
branch
from
October 3, 2026 11:19
7605c2f to
45a5ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This third slice of #241 adds stable question and option IDs, canonical decision-record validation, and shared-draft operations for appending options, suggestions, retitling, and reopening. Selected answers retain option IDs alongside their readable labels; existing persisted custom answers still derive correctly. Duplicate option IDs are refused without changing existing draft selections.
The existing keyed “Add an option” path stays in use. It is adapted to the wider stored definition type, with its persistence and retry tests retained. Canonical records remain a separate module until the later runtime layer connects them to the document and durable sidecar.
Review scope: 33 files; +876/−74 source lines and +1,173/−5 test lines. Merge after the replay layer. This introduces no new route or automatic Save behavior.
Validation: 137 focused question, record, Store, existing service, and agent-tool tests pass (515 assertions); full workspace/E2E types, repository CI, and formatting pass.