Jev 2: validate and replay bounded conversation events - #253
Merged
Merged
Conversation
MaggieAppleton
added this pull request to stack #254
October 3, 2026 06:11
MaggieAppleton
changed the title
MaggieAppleton
marked this pull request as ready for review
October 3, 2026 08:09
MaggieAppleton
force-pushed
the
maggie/jev-replay
branch
from
October 3, 2026 11:09
ee08b38 to
25614f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This second slice of #241 adds validated conversation events and deterministic state replay on top of the Jev foundation. Events check source attribution, thread versions, and capacity before changing state. Repeated event IDs are idempotent; corrections and contribution moves retain replayable history.
Replay copies only the changed thread and, for a move, its destination. Later transitions leave earlier states unchanged while avoiding repeated copies of the full event history. A review fix clears pending settlement and scoped-choice proposals when a resolution candidate closes a thread, matching direct decision replay. This layer contains no database writes or active chat workflow.
Review scope: 30 files; 2,257 source lines and 1,726 test lines. Merge after the foundation PR. Decision records and interpretation are the next layers.
Validation: 71 focused foundation and replay tests pass on the local fix, full workspace/E2E types and repository CI pass locally. All three required GitHub checks pass on the rebased head. Tests cover replay, corrections, invalid stored state, source provenance, and capacity.
Review fix: close pending choices