Restyle the decision card - #231
Open
MaggieAppleton wants to merge 5 commits into
Open
MaggieAppleton wants to merge 5 commits into
MaggieAppleton wants to merge 5 commits into
Conversation
Drop the Decision label row for a mark beside the question, lettered option rows with a trailing check, an always-last Add an option row, Discard/Save footer with in-place confirm, a stepper in place of question tabs, and a shared callout for a failed save. Adds DecisionIcon. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The preview deployment for chopin is ready. 🟢 Open app | Open Build Logs | Open Application Logs Last updated at: 2026-09-30 20:52:52 CET |
The approved design greys the primary action until an option is chosen. Next keeps free navigation in read-only views. Focus follows the primary button when Next lands on the last question. The alert-motion e2e now triggers a rejected save instead of an empty submit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The decision cards at the foot of the scroller wrap to more lines at 320px than the old card did, so the bottom distance settles at 40px (was exactly 24px). Bound it at 64px; a moved document is hundreds of pixels. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
Independent review (automated, designer asleep)Fixed and pushed
Checked, no change needed: draft/multi-question state, multiple-select and custom-answer mode switching, discard confirm, aria-busy/disabled fieldset, keyboard-only focus ring, tokens/btn utilities, fidelity to the jig CSS (sizes, spacing, colours, copy). Left as is
Checks: |
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1 of the decision card redesign: restyles
QuestionViewto the approved jig. Resolved/Decided rendering is unchanged.DecisionIconin@chopin/icons) leads the question title. Presence badges unchanged (PR 2).Discard(outline) /Save(primary, "Saving…", "Try again"); Discard swaps the footer in place to "Discard this decision?" withKeep it/Discard(destructive), same underlying cancel action.‹ header n/m ›, primary reads "Next" until the last question, then "Save". Per-question drafts preserved..plan-research-callout/.plan-research-badgewith a "Couldn't save" lead line.Decisions made
<input>, so long existing custom answers keep wrapping and the 4000-char limit is unchanged. An empty field is left open (not auto-closed on blur) so Save still reports "requires an answer".check()on options and the row focus ring all behave. Focus ring is drawn on the row via:has(:focus-visible).erroris one string.ChevronIcon size=16allowed in the question view (icon test),btn-outlineadded as a recognised tier in the token test, native-control registrations for the old question inputs removed (the inputs are now intentionally bespoke), anddynamic-packages.jsoncases/hashes renewed forquestion-view.tsxandicons/line.tsx.prefers-reduced-motion: no-preference(keeps the existing theme test's first reduced-motion block intact).title="Decision"tooltip as in the jig.Before / after (2x)
Note: the multi-question fixture is the read-only stored questionnaire (no live record), so selection states are not shown for it.
Checks
bun run fix,bun run ci,bun run types: passbun test: 1736 pass, 0 fail--project=fixtures), full project: 88 passed🤖 Generated with Claude Code