Make the button press subtle on large targets - #229
Merged
Merged
Conversation
…r one Default :active scale is now 0.99. .btn-icon, .btn-sm and data-press=small keep 0.96; full-screen backdrops opt out with data-press=none. Renew design-contract hashes for the touched dynamic owners. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every button pressed to
scale: 0.96. On large targets (sidebar rows, dialog and picker options, menu items, tabs, full-width buttons, even full-screen backdrops) that reads as a lurch, not a press.Change
0.99.0.96:.btn-icon,.btn-sm, and a new opt-indata-press="small"(toolbar cells, table action and rail controls, sidebar icon actions, comment gutter button).data-press="none"removes the press; used on the drawer and modal backdrops.data-press="wide"keeps its coarse-pointer 44px sizing; its separate0.99rule is gone because that is now the default.Medium buttons (
btn-md, e.g. "Delete document") move to the subtle press too.Before / after
Held press, dashed outline = resting bounds.
Checks
bun run fix,bun test(1729 pass),bun run types,bun run ciall pass. Measured in Chromium during a held press: wide 0.99,.btn-icon0.96,.btn-sm0.96.🤖 Generated with Claude Code