Require evidence before the Effect review bot opens PRs - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Effect review bot proposed PR #222 solely to remove a dependency suppression, without establishing a reachable bug. Require caller and lifecycle evidence, a concrete failure or measurable unnecessary work, preserved setup/cleanup ownership, and verification of the actual claim. Missing required checks now mean no PR; zero findings is explicitly successful.
Regenerated the workflow lock file. Schedule, permissions, and the five-PR limit are unchanged.
Also stabilizes the PostgreSQL job-lock lease regression: handle the expected rejection immediately, observe the actual lock wait, and wait for expiry using PostgreSQL’s clock.
Validation: workflow compilation;
bun run ci, types, build, 1,729 unit tests, and all 59 PostgreSQL tests pass. The repaired lease test also passes 10 consecutive runs.Acceptance gates