Fix VS Code integration tests on macOS - #4499
Open
cklin wants to merge 1 commit into
Open
Conversation
VS Code 1.131 removed the legacy Contents/MacOS/Electron compatibility executable on macOS. Upgrade @vscode/test-electron to 3.1.0 so the test harness resolves the executable from the application bundle metadata instead of trying to launch the removed path. Override jest-runner-vscode's transitive @vscode/test-electron dependency as well. Its declared 2.x range would otherwise cause npm to install a private 2.5.2 copy and leave the runner using the broken executable lookup despite the direct dependency upgrade. Increase the minimal-workspace activation polling and Jest timeouts because extension activation under VS Code 1.131 can take longer on macOS than the previous 30-second allowance. This preserves the activation assertion while avoiding a deterministic timeout on slower macOS hosts. These failures were observed only in local macOS runs. GitHub Actions runs the VS Code integration suite on Linux and Windows, where the existing tests were passing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d7e3c611-18b2-4bf2-8f9a-09e7a8d1ef8e
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VS Code integration-test harness for macOS compatibility.
Changes:
- Upgrades and overrides
@vscode/test-electronto 3.1.0. - Regenerates the dependency lockfile.
- Extends the minimal-workspace activation timeout.
Show a summary per file
| File | Description |
|---|---|
extensions/ql-vscode/package.json |
Upgrades and overrides the test-electron dependency. |
extensions/ql-vscode/package-lock.json |
Locks test-electron 3.1.0. |
extensions/ql-vscode/test/vscode-tests/minimal-workspace/activation.test.ts |
Allows slower macOS activation. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Generated file
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VS Code 1.131 removed the legacy
Contents/MacOS/Electroncompatibility executable on macOS, causing the existing test harness to launch a path that no longer exists. This PR upgrades@vscode/test-electronto 3.1.0 so the executable is resolved from the application bundle metadata.It also overrides the version used transitively by
jest-runner-vscode; without the override, npm installs a private 2.5.2 copy and the runner continues using the obsolete executable lookup.The minimal-workspace activation timeout is increased because extension activation on macOS can now exceed the previous 30-second polling allowance. These failures were specific to local macOS runs; GitHub Actions runs this suite on Linux and Windows, where it was already passing.
Testing
npm run test:vscode-integration