Skip to content

fix: use logger instead of print() in events.py #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

fix: use logger instead of print() in events.py #3965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/specify_cli/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,10 @@ def _run_inline(command_name, payload, project_root, timeout):
return result.returncode
return 0
except subprocess.TimeoutExpired:
print(f"Event {command_name} timed out", file=sys.stderr)
logger.error("Event %s timed out", command_name)
return 2
except Exception as e:
print(f"Event {command_name} error: {e}", file=sys.stderr)
logger.error("Event %s error: %s", command_name, e)
return 2


Expand Down Expand Up @@ -1070,9 +1070,8 @@ def install_integration_events(
if ev in canonical_to_native:
filtered[ev] = handlers
else:
print(
f"\u26a0\ufe0f {integration.key} does not support '{ev}' events; skipping",
file=sys.stderr,
logger.warning(
"%s does not support '%s' events; skipping", integration.key, ev,
)

# #3: an empty resolved map (--events false, or override disabling events)
Expand Down