Pin brace-expansion@1 to a patched release via override - #31
Merged
Conversation
The remaining high-severity brace-expansion advisories could not be resolved by 'npm audit fix' -- it converges without moving the pinned transitive copy. Adds a version-scoped override so the v1 line resolves to a patched release, leaving the v2 and v5 copies (already patched) untouched: brace-expansion@1 -> ^1.1.18 (was 1.1.13, via @eslint/eslintrc) Build, lint and tests pass.
There was a problem hiding this comment.
Pull request overview
Pins the vulnerable v1 brace-expansion dependency to a patched release without affecting other major versions.
Changes:
- Adds a version-scoped npm override for
brace-expansion@1. - Updates the lockfile from
1.1.13to1.1.18.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds the scoped dependency override. |
package-lock.json |
Locks the patched transitive dependency. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30, which cleared everything
npm audit fixcould reach. One high-severitybrace-expansionfinding remained —npm audit fixconverges without moving the pinned transitive copy.One copy was vulnerable:
eslint-plugin-github→@eslint/eslintrc→minimatch@31.1.131.1.18Adds a version-scoped override:
Scoping to the v1 line matters — a blanket override would drag the
2.1.4(mocha) and5.0.9(eslint) copies onto the wrong major. Both of those are already on patched releases and are left untouched.Resolves GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895.
Still outstanding after this
Two low severity findings for
diff(GHSA-73rr-hh4g-fpgx) viamocha. There is no clean fix available:mocharelease through the latest (11.8.0) declaresdiff: ^7.0.0, and the entire v7 line falls in the vulnerable6.0.0 - 8.0.2range.npm audit fix --force"fixes" it by downgrading mocha to11.3.0.diff@^8.0.4pushes mocha past the major it declares support for.This needs an upstream mocha bump. It is dev-only (test runner diff rendering), so leaving it.
Validation
npm testpasses (build + lint + 18 tests)