Support removing issue types - #2999
Open
zwick wants to merge 9 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c
Contributor
There was a problem hiding this comment.
Pull request overview
Adds empty-string support for clearing issue types in consolidated and granular issue tools.
Changes:
- Sends
"type": nullwhen clearing an issue type. - Bypasses form deferral to preserve explicit clears.
- Adds exact request-body tests and updates generated documentation.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents issue-type removal. |
pkg/github/issues.go |
Implements consolidated clear behavior. |
pkg/github/issues_test.go |
Tests set, omit, clear, and form bypass. |
pkg/github/issues_granular.go |
Implements granular clear behavior. |
pkg/github/granular_tools_test.go |
Tests granular clear and validation. |
pkg/github/__toolsnaps__/update_issue_type.snap |
Updates granular schema snapshot. |
pkg/github/__toolsnaps__/issue_write.snap |
Updates consolidated schema snapshot. |
docs/insiders-features.md |
Updates generated insiders documentation. |
docs/feature-flags.md |
Updates generated feature documentation. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Balanced
zwick
commented
Aug 3, 2026
Comment on lines
+2227
to
+2234
| deferToForm := shouldDeferToForm(ctx, deps, req, args, issueWriteFormParams) | ||
| if method == "update" { | ||
| if issueType, ok := args["type"].(string); ok && issueType == "" { | ||
| // The form replaces an empty type with the current type, so execute | ||
| // directly to preserve the clear and any co-submitted values. | ||
| deferToForm = false | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was a little awkward, but a previous attempt to handle this null|string value was requiring a larger change to the Form to support a null value. Added this to bypass that deferment instead of changing how the form validates nullable data to keep this change focused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow consolidated
issue_writeand granularupdate_issue_typeto remove an issue type with an empty-string input.Why
Related: github/plan-track-agentic-org#193
What changed
typeto leave it unchanged, use a non-empty string to set it, or use an empty string to clear it."type": null.MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lintpkg/githubtestsFocused tests cover omitted, non-empty set, empty-string clear, required granular input, exact PATCH JSON, UI-capable clear bypass, and a mixed clear-plus-state call using the existing REST/GraphQL transport split. Earlier live API validation used locally built stdio server calls without the MCP App form path; consolidated and granular tools both set and cleared a disposable issue type, read back
type: null, and the issue was closed.Docs