Handle unsupported issueFieldValues enrichment in search_issues - #2897
Handle unsupported issueFieldValues enrichment in search_issues#2897kerobbi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the search_issues tool’s custom-field enrichment to be best-effort so it no longer fails on GitHub Enterprise Server instances whose GraphQL schema does not support issueFieldValues (e.g., GHES 3.20.x). The search now returns REST results even when GraphQL enrichment is unavailable, aligning with the existing “best-effort enrichment” behavior in issue_read get.
Changes:
- Made
search_issuesGraphQL-basedfield_valuesenrichment non-fatal and record enrichment failures on the request context. - Ensured
search_issuesreturns REST hits withfield_valuesomitted when enrichment cannot be performed. - Added a unit test covering the unsupported-schema (
issueFieldValuesmissing) path.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues.go | Makes search_issues field-value enrichment best-effort (do not fail the search when enrichment fails). |
| pkg/github/issues_test.go | Adds coverage for the unsupported GraphQL schema scenario to ensure REST results still return. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
|
Hi @kerobbi, This fixes
Here issueFieldValues is used as a query variable / input type (IssueFieldValueFilter) rather than a response field, so the graceful-degradation change here doesn't cover it. Can the same best-effort treatment be applied to list_issues, or should a follow-up PR be opened? |
Summary
Makes the custom field value enrichment in
search_issuesbest-effort, so a search no longer fails when the server's GraphQL schema doesn't support theissueFieldValuesfield (e.g. GHES).Why
Fixes #2831
What changed
search_issuesreturns its REST hits (withfield_valuesomitted) when enrichment is unavailable, matching howissue_readgetalready treats the same enrichmentTest_SearchIssues_FieldValuesEnrichmentUnsupportedcovering the unsupported-schema pathMCP impact
search_issuesnow degrades gracefully instead of failing when field value enrichment is unsupportedSecurity / limits
Tool renaming
Lint & tests
./script/lint./script/testDocs