Repository navigation
Fix the cancelled test matrix, the example scripts and stale config - #990
Merged
Merged
Conversation
GitHub retired the macos-14 images on 2026-11-02. The job now ends with "The configuration 'macos-14-arm64-us-default' is not supported", which marks every push to master as cancelled. Use macos-15 and macos-26 in the test and post-publish matrices, set fail-fast: false, and only cancel superseded runs on pull requests so pushes to master always finish.
example.py imported print_row from a util.db module that does not exist, and most scripts connected to a PLC at import time. Import from s7, move the connections under a __main__ guard, and size the buffer in boolean.py so set_int no longer refuses it. read_multi.py and write_multi.py built ctypes S7DataItem arrays and checked a Result field the client never sets. Rewrite them around read_tags and the dict form of read_multi_vars/write_multi_vars, and lead doc/multi-variable.rst with the same.
Give AsyncClient its own API page with its concurrency model and the differences from Client. Extend the thread-safety page with what the heartbeat thread does, what the internal lock covers, where callbacks run, and how max_parallel is chosen and overridden. Correct the connecting page, which described snap7 as an alias for s7; it is the other way round.
The hook only checked snap7, while tox and the contribution guide check snap7, s7, tests and example. Widen it and give its environment pytest, pytest-asyncio, pytest-bdd and hypothesis so the test decorators are typed. Drop the exclude for snap7/protocol.py, which does not exist.
The classifier said POSIX only, but the library is pure Python and CI tests it on Windows, Linux and macOS.
The commented-out 'sudo pytest -m partner' dates from when the partner tests needed a privileged port, and allowlist_externals = sudo existed only for it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test workflow showed "cancelled" on recent
masterpushes, including the 3.4.0 release, because the retiredmacos-14runner failed and cancelled the rest of the matrix.example/example.pyfailed on import, and two examples taught the old ctypes path.No file under
snap7/ortests/is changed.Commits
Testing
snap7/ortests/is changed; CI on this PR will show whether it is local.🤖 Generated with Claude Code