Repository navigation
Let read_tags and read_multi_vars read more than 20 items - #989
Merged
Merged
Conversation
read_multi_vars raised ValueError when given more than MAX_VARS (20) items, before the read optimizer ran, so read_tags failed above 20 tags although the optimizer already spreads a read over several requests. - The dict form of read_multi_vars and read_tags accept any number of items, in both clients. The ctypes form of read_multi_vars and write_multi_vars keep the MAX_VARS limit. - optimizer.packetize takes a max_items argument (default 20) and starts a new packet when the current one holds that many blocks, next to the request and reply byte budgets. With a PDU of 480 bytes or more, over 20 small blocks used to fit the byte budgets of one request. The client passes MAX_VARS. - read_tags raises NotImplementedError for a symbolic tag, as read_tag does, in both clients. MAX_VARS stays a public name with the value 20.
gijzelaerr
force-pushed
the
fix/read-tags-above-20
branch
from
November 11, 2026 13:33
888c8b1 to
bd67b17
Compare
gijzelaerr
enabled auto-merge (squash)
November 11, 2026 13:33
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_multi_varsraisedValueErroraboveMAX_VARS(20) before the optimizer ran, although the optimizer already splits requests across PDUs. The packetizer now also respects a 20-items-per-PDU limit, andread_tagsrefuses symbolic tags the wayread_tagdoes.MAX_VARSstays a public name.Commits
Testing
end-of-file-fixeron.dockerignore, which is a symlink artefact on Windows.🤖 Generated with Claude Code