Repository navigation
Refuse tags with no known size in strict parse_tag - #974
Merged
Merged
Conversation
Moves the codec from snap7.client to snap7.tags as decode_tag and encode_tag. The private names stay as aliases, because released ha-s7 versions import them.
Also gives S5TIME a size and a decoder. Writing it stays unsupported, since there is no set_s5time.
# Conflicts: # CHANGES.md # tests/test_tags.py
This was referenced Nov 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #970. Based on #973, because both change the codec in
tags.py; this PR's diff is only its own commits.parse_tagaccepted addresses such asDB1.DBW0:BOGUSandDB1.DBB0:STRING, and the failure only appeared when.sizewas read. An application that validates addresses withparse_tagtherefore accepted ones that fail on every read.strict=True, the default,parse_tagnow raisesValueErrorfor a type with no known size.strict=Falseand the explicitPLC4XTag.parse/NodeS7Tag.parsebehave as before.S5TIMEnow has a size of 2 and decodes with the existingget_s5time. Writing it still raisesValueError, because there is noset_s5time.Behaviour change: code calling
parse_tagwith default arguments on such an address now gets theValueErrorat parse time instead of at first use.Checks: full test suite, mypy, ruff and pre-commit pass locally on Windows. Not tested against a real PLC, and
S5TIMEdecoding only compares againstget_s5time.