Repository navigation
fix(cli): Answer accepted envelopes with 200 and the event ID - #2432
Merged
Merged
Conversation
sentry-elixir only treats a delivery as sent when it gets HTTP 200 with a
JSON body that has an id. It retries anything else at 1, 2, 4 and 8 seconds,
which blocks its queue, so one event arrived five times and the rest were
lost. Answer the way Relay does: 200 with {"id":"<event_id>"} from the
envelope header, or {} when there is none, on every plain and session
ingest path. Other status codes are unchanged.
Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
The viewer integration tests post to a real receiver, which now answers accepted envelopes with 200 and the event ID. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
MathurAditya724
approved these changes
Nov 19, 2026
MathurAditya724
left a comment
Member
There was a problem hiding this comment.
Reviewed and retested with current main. Typecheck, lint and the full workspace test suite pass. An independent real-HTTP probe passed 64 deliveries across plain and session ingest routes, identity/gzip/deflate/br compression, and lowercase/uppercase/hyphenated/missing event IDs. Acknowledgements are HTTP 200 with JSON; error paths and retention behavior remain covered by the suite. Checked the official sentry-elixir transport implementation's 200/JSON success contract. No actionable findings.
This was referenced Nov 19, 2026
sentry-junior Bot
added a commit
that referenced
this pull request
Nov 19, 2026
Keep #2432's 200 JSON acknowledgement for session ingest, recording activity only for accepted envelopes, on the session ID resolved once at the top of the handler. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
sentry-junior Bot
added a commit
that referenced
this pull request
Nov 19, 2026
Keep #2432's 200 acknowledgement next to the 400 rejection: ingest now returns a tagged result, reads the envelope header once, and both receivers answer through the shared ingestResponse. Co-Authored-By: Aditya Mathur <57684218+MathurAditya724@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry-elixir only counts an envelope as sent when it gets a 200 with a JSON
id. Local answered 204 with no body, so Elixir retried each envelope at 1, 2, 4 and 8 seconds and blocked its queue: one event showed up five times and the rest never arrived.Local now answers with a 200 and the event id, like Relay, on every ingest path, plain and session:
Before:
After:
The id comes from the envelope header's
event_id, without hyphens, as Relay prints it. Envelopes without one, such as logs or sessions, get200 {}. The error responses (400, 410, 413, 415, 503) don't change.As far as I can tell from their transport code, the browser, Go, PHP, Ruby and Rust SDKs treat any 2xx as success, so they shouldn't notice the change.
via @MathurAditya724.
--
View Session [Sentry]