Repository navigation
feat(mcp): Record side quest next-call fingerprints so taken quests can be measured #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d9103dd
feat(mcp): Record side quest next-call fingerprints so taken quests c…
sentry-junior[bot] 0bd97c6
Merge remote-tracking branch 'origin/main' into feat/mcp-side-quest-t…
sentry-junior[bot] 2705504
Merge remote-tracking branch 'origin/main' into feat/mcp-side-quest-t…
sentry-junior[bot] bbbf48f
ref(mcp): Hash side quest fingerprints with SHA-256
sentry-junior[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if next is specifically for tools then how will we track non-tool calling side quests? For context this is what the related_issues sidequest curr shows up as in mcp responses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then agents do some decision making (there was no additional user ask to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this only covers quests that have
next. Tip-only quests (js_source_maps,missing_user_identity,missing_stack_trace) have nothing to match, because the fix happens in the user's code, outside MCP. For those we'd have to look at outcomes instead, like the quest no longer showing up for that project.Your example is the case this is built for. The agent's next call,
get_sentry_resource(resourceType='issue', resourceId='SENTRY-5PCN'), hashes to the same fingerprint as thenextentry, so it counts as taken. If the agent skipped that and went straight toupdate_issueon SENTRY-5PCN, the fingerprint wouldn't match, but #2387'sissue_idsattribute still catches it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's exactly what we want to count. The user didn't have to ask: the agent followed the quest on its own. Its
get_sentry_resourcecall for SENTRY-5PCN matches the offered call, so it shows up as taken.