Repository navigation
Conversation
C# events do not pass through the native SDK, so they did not get device.connection_type or device.connection_effective_type, which sentry-java 8.60.0 and sentry-cocoa 9.30.0 report on native events. UnityEventProcessor now reads both values from the native SDK on the main thread. On Android, SentryJava reads the cached connection from AndroidConnectionStatusProvider through JNI, and new ProGuard rules keep the class names. On iOS and macOS, a new bridge function reads the device entry of the Cocoa extra context. This needs the Device fields from getsentry/sentry-dotnet#5745.
The feature needs Device.ConnectionType and Device.ConnectionEffectiveType from getsentry/sentry-dotnet#5745, which is merged but not released. sentry-dotnet main needs .NET SDK 10.0.402, so global.json moves too. Replace this commit with the update to the next sentry-dotnet release.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android, iOS, and macOS, C# events now report
device.connection_typeanddevice.connection_effective_type(for example4gor5g). sentry-java 8.60.0 and sentry-cocoa 9.30.0 already report these fields on native events, but C# events do not pass through the native SDKs.UnityEventProcessornow reads both values from the native SDK on the main thread: over JNI on Android, and through a new bridge function on iOS and macOS.Notes
The commit "Update sentry-dotnet to c9ad2be4" points
src/sentry-dotnetat unreleased main, because the newDevicefields come from getsentry/sentry-dotnet#5745. That commit gets replaced by the update to the next sentry-dotnet release before merge. The Android path calls internal sentry-java classes (AndroidConnectionStatusProvider,NetworkConnection), so new ProGuard rules keep their names. Device checks are still open: the Android emulator, the iOS Simulator, and a real iPhone on cellular data.Closes #1932