feat(core)!: Remove sendDefaultPii in favor of dataCollection - #22918
Merged
Conversation
s1gr1d
requested review from
andreiborza,
chargome,
isaacs and
nicohrubec
and removed request for
a team
July 31, 2026 14:25
s1gr1d
marked this pull request as draft
July 31, 2026 14:25
Contributor
size-limit report 📦
|
chargome
force-pushed
the
sig/removeSendDefaultPii
branch
2 times, most recently
from
August 3, 2026 13:55
49cb58b to
a6abd4f
Compare
`PII_HEADER_SNIPPETS` was only consumed by the removed `sendDefaultPii` bridge and is not part of the public API, so it is now unreachable. The `userInfo` JSDoc still advertised the pre-v11 default of `false`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
sig/removeSendDefaultPii
branch
from
August 3, 2026 15:41
a6abd4f to
cf92ec0
Compare
Member
|
bugbot moch |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cf92ec0. Configure here.
chargome
marked this pull request as ready for review
August 4, 2026 10:07
Member
|
@nicohrubec I think we can trim down the migration docs here a bit more, but we need to do that anyway for the whole release |
Member
|
@chargome jup I think it's fine to just do that in one pass in the end, for now I'd focus on completeness |
nicohrubec
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all occurrences of
sendDefaultPiiand also updates the migration docs.Closes #22708