fix(build): name Etienne Lescot as the Windows publisher - #246
Merged
Conversation
Windows listed the installed app's publisher as the original creator. electron-builder derives it from package.json `author.name` only (appInfo.companyName -> NSIS COMPANY_NAME), so that is the field that had to change; there is no win.publisherName override in electron-builder 26. Siddharth Vaddem moves to `contributors`; README and LICENSE keep crediting him as the original creator. The appx target was already correct via its own publisherDisplayName.
The 1.8.0 sync turned `onStatus` from a bare phase into an `SttRendererStatus` object carrying chunk progress, but the CLI captions runner still declared the old `(phase) => void` callback. Neither branch was broken alone; the rebase in #245 put them together and main has not typechecked since. `onStatus` now also fires once per transcribed chunk rather than once per phase, so log only on a phase change -- otherwise a long transcription emits one identical line per chunk.
… tag docs.yml had an `on: release` trigger so the /download page could pick up the new assets. It could never work: a release event runs with github.ref = refs/tags/vX.Y.Z, and the github-pages environment allows only `main` to deploy, so the deploy job failed on every stable release. Pre-releases skipped the build entirely, which is why v1.8.0 was the first release to surface it. Replace the trigger with a workflow_dispatch fired by build.yml once the release is published. Dispatching against main satisfies the environment policy and publishes main's docs rather than the release branch snapshot.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates package authorship metadata, stable-release documentation rebuilds, documentation deployment triggers, and CLI transcription status logging. ChangesPackage metadata
Release documentation workflow
CLI transcription status
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yml:
- Around line 511-521: Update the “Refresh the docs /download page” step to
capture the run ID returned by `gh workflow run docs.yml --ref main`, then
monitor that dispatched run until completion with the GitHub CLI and fail the
release step if the docs build or deployment fails. Preserve the existing
stable-release condition and main-branch dispatch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 40906b8d-e1f4-4f5d-a045-cfcab564b700
📒 Files selected for processing (3)
.github/workflows/build.yml.github/workflows/docs.ymlsrc/cli/CliCaptionsRunner.tsx
`gh workflow run` only fires the dispatch and exits, so a docs build or Pages deploy that failed left the release green while /download kept serving the previous version's binaries. Track the dispatched run by diffing the newest workflow_dispatch run id before and after the dispatch, watch it to completion, and fail the step on anything but success. A cancelled run is only warned about: docs.yml cancels in-flight runs on the same ref, so that means a newer main run superseded this rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows listed the installed app's publisher as the original creator (see the Apps list entry for 1.8.0-rc.7 and earlier).
electron-builder derives that string from
package.jsonauthor.nameand nowhere else:appInfo.companyNamereturnsmetadata.author.name(app-builder-lib/out/appInfo.js:90)NsisTarget.js:488setsCOMPANY_NAMEfrom it — that is thePublishervalue Windows showsAppxTarget.js:184usespublisherDisplayName || companyName, which is why the Store package was already correctThere is no
win.publisherNameoverride in electron-builder 26 — that key was removed from thewinschema and now fails config validation outright.So
author.namebecomes Etienne Lescot. Siddharth Vaddem moves tocontributors; README and LICENSE continue to credit him as the original creator, and the LICENSE copyright line is untouched.Already shipped on
release/v1.8.0(tagv1.8.0was re-cut at40444d5aand rebuilt). This ports it to main so 1.8.1 doesn't regress.Summary by CodeRabbit
Bug Fixes
Documentation
Chores