fix NamedTupleParser::to_schema() for non-DefaultVal fields - #730
Merged
Merged
Conversation
gg-sr
force-pushed
the
schema-no-default-val
branch
from
September 29, 2026 02:08
ede821e to
29a3508
Compare
Also properly pass processors when computing the default, so e.g. naming matches the schema.
gg-sr
force-pushed
the
schema-no-default-val
branch
from
September 29, 2026 02:30
29a3508 to
1e29750
Compare
Collaborator
|
@gg-sr thanks for the contribution. I am merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some structs may be
DefaultVal(and indeed have default values), but cannot be added automatically to a schema (because their default cannot be converted to aReflectionType). This skips these values when creating schemas.Also properly pass processors when computing the default, so e.g. naming matches the schema.