Skip to content

notify Slack when staging test builds are ready - #9026

Open
atavism wants to merge 4 commits into
mainfrom
atavism/staging-build-slack
Open

notify Slack when staging test builds are ready#9026
atavism wants to merge 4 commits into
mainfrom
atavism/staging-build-slack

Conversation

@atavism

@atavism atavism commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Added Slack notifications for successful macOS staging test builds.
    • Notifications include the branch, commit, backend environment, and a link to the build run.
    • Updated macOS staging build configuration to support unsigned builds more reliably.

Copilot AI lite review requested due to automatic review settings September 2, 2026 14:59
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1f2fb9aa-9638-4447-a693-7ceba4735fa0

📥 Commits

Reviewing files that changed from the base of the PR and between 87fdf80 and 72e1500.

📒 Files selected for processing (2)
  • .github/workflows/build-macos.yml
  • .github/workflows/staging-test-build.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/build-macos.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/staging-test-build.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The workflows update secretless macOS signing permissions and variables. They also add a conditional Slack notification after a successful build-macos job.

Changes

Staging workflow updates

Layer / File(s) Summary
Secretless macOS signing configuration
.github/workflows/build-macos.yml
The macOS build removes id-token: write and uses Flutter-specific variables to disable code signing.
Conditional Slack notification job
.github/workflows/staging-test-build.yml
The workflow runs notify when build-macos succeeds without cancellation. It sends the branch, short commit SHA, backend environment, run URL, and updated macOS staging build message through SLACK_WEBHOOK_URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 72e15

The workflow changes add a conditional Slack notification for successful staging macOS builds and adjust secretless signing settings. No concrete merge-blocking risk is identified in the supplied context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: sending a Slack notification when staging test builds are ready.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch atavism/staging-build-slack

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The newly introduced Slack notification text appears to include incorrect/copy-pasted wording that may confuse recipients.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an explicit Slack notification step to the staging-backed test build workflow so the team gets alerted when the macOS staging test build completes successfully.

Changes:

  • Introduces a new notify job that runs after build-macos succeeds.
  • Formats a Slack message payload in bash (using jq) and posts it via slackapi/slack-github-action.
File summaries
File Description
.github/workflows/staging-test-build.yml Adds a post-build Slack notification job for successful staging test macOS builds.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/staging-test-build.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants