Repository navigation
feat(cli): floo logs build and floo logs --preview replace deploys logs and previews logs - #400
Conversation
…gs and previews logs `floo logs build [DEPLOY_ID] [--follow]` shows a deploy's build logs, by default the latest deploy. `--preview <branch>` on `floo logs` (and its query and tail) reads the runtime logs of the preview's latest deploy, with every runtime log filter; `floo logs build --preview <branch>` shows that deploy's build logs. `floo deploys logs` and `floo previews logs` fail with COMMAND_REMOVED and name the replacement. The guidance checker now skips an option's value, so `floo logs --preview feat-x` is not read as an unknown subcommand of `floo logs`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw476uDAxxXQi632Y2Eq
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60f5ea2da2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`floo logs --preview feat-x build` read the app's latest deploy, because the parent's --preview was dropped. It now selects the preview's deploy, and a deploy ID with a parent --preview stops with INVALID_ARGUMENTS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw476uDAxxXQi632Y2Eq
|
@codex review Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d4909689b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ommand `floo logs --preview feat-x query` read app-wide logs, because query and tail used only their own options. A subcommand's options now fall back to the ones before it (the subcommand wins; --live and --tail stay its own), and --preview with --env, --deployment or --requests across the two levels stops with INVALID_ARGUMENTS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw476uDAxxXQi632Y2Eq
|
@codex review Generated by Claude Code |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Step 4 of the deploy rework (getfloo/floo#4262), the logs row of the fold table:
logs,deploys logsandpreviews logsbecome onefloo logs.floo logs build [DEPLOY_ID] [--app] [--follow]shows a deploy's build logs, by default the latest deploy. It is the olddeploys logs, unchanged.floo logs --preview <branch>(andlogs query/logs tail --preview) reads the runtime logs of the preview's latest deploy. Every runtime log filter works with it (--since,--search,--severity,--live...), whichpreviews logsnever had. It conflicts with--env,--deploymentand--requests.floo logs build --preview <branch>shows that preview deploy's build logs.floo deploys logsandfloo previews logsfail withCOMMAND_REMOVEDand name the replacement.Issue Closure
Part of getfloo/floo#4262 (step 4). Does not close it.
Changes
src/cli.rs:LogsSubcommands::Build,LogsOptions.preview;DeploysSubcommands::LogsandPreviewsSubcommands::Logsremoved; runtime log dispatch moved intoruntime_logsso every arm reaches the post-command update step; help examples updated.src/commands/deploys.rs:logstakespreview.src/commands/previews.rs:latest_deploy_idreplacespreviews::logs; thepreviews statusnext hint namesfloo logs --preview.src/commands/logs.rs:--previewsets the deployment and thepreviewenv.src/commands/removed.rs: two entries.src/commands/skills.rs: the two removed read-only permissions go (logsalready covers them).src/cli/guidance_tests.rs: the guidance checker skips an option's value, sofloo logs --preview feat-xis no longer read as an unknown subcommand offloo logs. A stale subcommand after an option value is still caught (test added).Test Plan
cargo fmt,cargo clippy --all-targets -- -D warningscargo test: all pass, with new mock tests forlogs --preview,logs build --previewandlogs build <id>, clap tests for the conflicts, and a removed-command case.Discovered Issues
None.
Generated by Claude Code