Repository navigation
feat(cli): floo deploy --rebuild and --restart replace floo redeploy - #399
Merged
Merged
Conversation
floo deploy --rebuild builds the app's current commit again and floo deploy --restart starts dev again with the current env vars, both without pushing. The app is --app, or the one in floo.app.toml; --service narrows either, and --skip-migrations goes with --rebuild. Clap rejects the redeploy flags on a normal deploy and the deploy flags with them. The folder mode of floo redeploy, which created the app and imported env files before deploying, is gone with --sync-env: floo deploy creates apps from the plan, and floo env import loads env files. That removes the upload-era preflight modes and the env sync code. floo deploy now names a legacy floo.toml instead of saying there is no config. floo redeploy fails with COMMAND_REMOVED naming its replacement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eufw476uDAxxXQi632Y2Eq
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
floo deploy --rebuildbuilds the app's current commit again, andfloo deploy --restartstarts dev again with the current env vars. Neither pushes. Together they replacefloo redeploy. This is the "Rebuild the same commit" row of the deploy rework plan (getfloo/floo#4262, step 4).Issue Closure
Part of getfloo/floo#4262 (step 4, cut the old surface). Does not close it.
Changes
floo deploygains--rebuild,--restart,--app,--serviceand--skip-migrations. The app is--app, or the one in floo.app.toml in the path. Clap rejects--app/--servicewithout one of the two modes,--skip-migrationswithout--rebuild, and the modes with--github,--hostedor--name.--preflightpreviews either without signing in.floo redeployis gone, along with--sync-env. It created the app and imported env files before deploying. Nowfloo deploycreates apps from the plan, andfloo env importloads env files. That removes the upload-era preflight modes,sync_env_vars_if_needed,parse_env_file_softand the unusedFlooClient::create_app(about 1,150 lines).floo deployon a folder with a legacy floo.toml now saysLEGACY_CONFIGinstead ofNO_CONFIG_FOUND. The old redeploy path did this, and a test caught the gap.floo redeployfails withCOMMAND_REMOVEDnamingfloo deploy --rebuild, and the message points at--restartfor env changes. The CLI's own hints (env set/unset, promote with no dev deploy,deploys --help) and the skill permissions name the new flags.Test Plan
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test(2,022 tests pass).rebuild_and_restart_flags_only_go_with_each_other(clap rules) andtest_deploy_rebuild_without_config_names_the_app_flag(outside a folder, each mode names--app;floo redeploynames its replacement).floo deploy --rebuildor--restart. Removed the tests for paths that no longer exist: folder-mode app creation,--sync-env, upload env-file validation and theredeploy --preflightparity checks.Discovered Issues
status.py,deploy_plan.py,last_push.py,restart_prepare.py,cron.py, the diagnostics registry,projects/service.py), the KB and floo-docs still sayfloo redeploy. A floo PR follows once this merges, with the vendored command tree.Generated by Claude Code