Scope compaction outcome parsing to OMP - #2957
Merged
ymichael merged 1 commit intoSep 2, 2026
Merged
Conversation
ymichael
force-pushed
the
bb/fixer-scope-omp-compaction-outcomes-thr_9yjrmn4jkp
branch
from
September 2, 2026 20:45
b0ccf49 to
f2bdd0b
Compare
ymichael
deleted the
bb/fixer-scope-omp-compaction-outcomes-thr_9yjrmn4jkp
branch
September 2, 2026 20:51
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The ACP bridge classified every successful manual-compaction response by looking for OMP-specific phrases such as
compaction failed. That policy leaked across dialects, so a generic ACP or OpenCode response describing an earlier failed attempt could be reported as a failed compaction even when the agent's final result was successful.What changed
How you verified
pnpm exec turbo run test typecheck --filter=@bb/provider-bridge-acp --force(307 tests passed)pnpm exec turbo run test --filter=@bb/server --force -- "test/public/public-thread-compaction.test.ts"(4 tests passed)pnpm exec turbo run build:types --filter=@get-bb/plugin-sdk --forcepnpm exec turbo run test --filter=@bb/plugin-api-map --force(75 tests passed; public SDK inventory unchanged)pnpm exec oxfmt --check packages/provider-bridge-acp/src/bridge/bridge.ts packages/provider-bridge-acp/src/bridge/bridge.test.ts packages/provider-bridge-acp/src/dialect.tsgit diff --check origin/main...HEADFollow-up to #2293.