Repository navigation
fix(docker): install patchelf so GenVM post-install can patch prebuilt trees - #1828
Conversation
…t trees genvm-manager v0.6-dev (26b2ff4d) dropped lief from post-install. When the ELF interpreter baked into bin/genvm-modules is absent on the host, it now shells out to patchelf and fails if it is not on PATH. The E2E pipeline builds GenVM on the runner and injects it with GENVM_SOURCE_MODE=prebuilt, so the interpreter path points at the runner's build directory and the Studio image build fails at post-install. Older post-install versions bundle lief and ignore the extra package.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
Problem and outcome
The release gate #1670 cannot pass E2E: the Studio image build fails before any test runs (run 43941347030).
Cause: genvm-manager
v0.6-devcommit26b2ff4d("drop the runner download and lief from post-install", 2026-11-16) removed the bundled lief patcher. When the ELF interpreter baked intobin/genvm-modulesis missing on the host, post-install now runspatchelf --set-interpreter <genvm>/lib/libc.soand raises ifpatchelfis not on PATH. The E2E pipeline builds GenVM on the runner and injects it withGENVM_SOURCE_MODE=prebuilt, so the baked path is the runner's build directory, which does not exist inside the image.Outcome: the
genvm-runtimestage installspatchelf, so post-install can repoint the interpreter.Non-goals: no change to the GenVM pin (
v0.6.0-rc14), to the acquisition modes, or to runtime behavior.Implementation and validation
apt-get installline indocker/Dockerfile.backend(genvm-runtimestage, shared by jsonrpc and consensus-worker).patchelf0.18.0 installs fromnoble/universeonubuntu:24.04, the stage's base image (checked locally).install/lib/python/post-install/__main__.pyat8bc7e29a): withpatchelffound byshutil.which, the failing branch runs the patch and continues.Risk: low. Post-install versions that still bundle lief (the pinned release) never call
patchelf, so the release-mode image is unchanged apart from the extra package.Rollback: revert this commit.