Repository navigation
docs(validators): owner signs wallet calls, vesting-owned wallets, set-identity overwrites - #770
Conversation
…t-identity overwrites A Bradbury operator with a vesting-funded validator wallet ran `genlayer staking set-identity` with both their owner and operator accounts; both reverted with OwnableUnauthorizedAccount. The setup guide did not say who signs, what a vesting contract changes, or that set-identity replaces every identity field. - Managing Your Validator: deposit, exit, claim and set-identity are onlyOwner on the validator wallet; examples pass --account owner, and the operator key can't sign them. - set-identity replaces all nine identity fields; omitted fields are cleared. The example now passes several fields. - New "If You Staked from a Vesting Contract": the vesting contract owns the wallet; the beneficiary signs the `genlayer vesting validator` commands; `validator-info` shows "Source: vesting (owner is a contract)"; --vesting when the lookup fails. Checked against genlayer-cli v0.40.0-rc.5 (the npm rc tag) and ValidatorWalletBlueprint.sol (validatorDeposit/Exit/Claim and setIdentity are onlyOwner; setIdentity assigns the whole struct). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Wallet ownership and management instructions pages/validators/setup-guide.mdx |
The guide specifies owner signing for standard staking commands, explains that omitted identity fields are cleared, and provides management commands for vesting-owned wallets. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested reviewers: jmlago
Merge Risk: 
Minimal · previous review 1ef50
-
This is a documentation-only update that explains owner and vesting-contract signing for validator operations. No merge-blocking issue was found.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title follows Conventional Commits with the docs(validators) type and scope. It names the three main changes: owner signing, vesting-owned wallets, and set-identity overwrites. All three appear in the summary and description. The title is long at 90 characters, but it is specific and relevant.
Full details: Description check
-
Explanation
The description explains the problem: a Bradbury operator's owner and operator calls reverted with OwnableUnauthorizedAccount because the wallet was funded through vesting. It lists each documentation change by section. It also states what was checked against genlayer-cli v0.40.0-rc.5 and the ValidatorWalletBlueprint.sol contract. It does not follow the template's Conventional Commits guidance for the title, but the title is already in that format. The template's Description section is filled in with a detailed explanation. Closing an issue is not applicable, and no issue reference is given. The description is complete and meets the template's intent.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ubuntu-latest now resolves to Ubuntu 26.04, and Playwright 1.55 can't
install its browsers there ("Playwright does not support chromium on
ubuntu26.04-x64"), so every PR fails the E2E check at the install step
(run 40668388090 on #770, and the 2026-10-26 run). Pin the job to
ubuntu-24.04 until @playwright/test is upgraded to a release that
supports 26.04.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Why
A Bradbury operator ran
genlayer staking set-identity <wallet> --moniker ...with their owner account and then their operator account. Both reverted withOwnableUnauthorizedAccount. Their validator wallet was funded through vesting, so the wallet's owner is the vesting contract and they are its beneficiary. The setup guide gave them no way to know this.What changes (
pages/validators/setup-guide.mdx)--account owner, and the text says the operator key can't sign them.--moniker.genlayer vesting validator deposit / exit / claim / set-identity / listcommands;stakingversions revert;staking validator-infoshowsSource: vesting (owner is a contract);--vestingif the CLI can't find the vesting contract.Checked against
v0.40.0-rc.5, which is whatnpm install -g genlayer@rcinstalls: command names, options, the--accountdescription "must be validator owner", thevalidator-infosource line, and the identity fieldsvalidator-infoprints (all except the extra CID).ValidatorWalletBlueprint.sol:validatorDeposit,validatorExit,validatorClaimandsetIdentityareonlyOwner, andsetIdentityassigns the whole identity struct.docs/validator-guide.md(genlayer-cli docs: clarify GenLayerJS wallet provider flow #429).Requested by genlayer-cli on Darien's behalf. Darien merges.
🤖 Generated with Claude Code
Summary by CodeRabbit