Skip to content

docs(validators): owner signs wallet calls, vesting-owned wallets, set-identity overwrites - #770

Merged
dohernandez merged 2 commits into
mainfrom
docs/setup-guide-vesting-owner
Oct 28, 2026
Merged

dohernandez merged 2 commits into
mainfrom
docs/setup-guide-vesting-owner

Conversation

@dohernandez

@dohernandez dohernandez commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Why

A Bradbury operator ran genlayer staking set-identity <wallet> --moniker ... with their owner account and then their operator account. Both reverted with OwnableUnauthorizedAccount. Their validator wallet was funded through vesting, so the wallet's owner is the vesting contract and they are its beneficiary. The setup guide gave them no way to know this.

What changes (pages/validators/setup-guide.mdx)

  • Wizard step 3 (funding source): says that with a vesting contract, the vesting contract owns the wallet, and links to the new section.
  • Managing Your Validator: deposit, exit, claim and set-identity are owner-only calls on the validator wallet. The examples now pass --account owner, and the text says the operator key can't sign them.
  • set-identity warning: each call replaces all nine identity fields, and omitted fields are cleared. The example passes several fields instead of only --moniker.
  • New "If You Staked from a Vesting Contract":
    • the beneficiary signs the genlayer vesting validator deposit / exit / claim / set-identity / list commands;
    • the staking versions revert;
    • staking validator-info shows Source: vesting (owner is a contract);
    • add --vesting if the CLI can't find the vesting contract.

Checked against

  • genlayer-cli tag v0.40.0-rc.5, which is what npm install -g genlayer@rc installs: command names, options, the --account description "must be validator owner", the validator-info source line, and the identity fields validator-info prints (all except the extra CID).
  • genlayer-consensus ValidatorWalletBlueprint.sol: validatorDeposit, validatorExit, validatorClaim and setIdentity are onlyOwner, and setIdentity assigns the whole identity struct.
  • The wording follows the CLI's own docs/validator-guide.md (genlayer-cli docs: clarify GenLayerJS wallet provider flow #429).

Requested by genlayer-cli on Darien's behalf. Darien merges.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that vesting contracts own their validator wallets and that beneficiaries should use vesting-specific commands to manage them.
    • Explained who must sign validator actions and when standard staking commands are unavailable for vesting-owned wallets.
    • Added guidance on identifying vesting-owned wallets, selecting a beneficiary or vesting address, and how identity updates replace all fields.

…t-identity overwrites

A Bradbury operator with a vesting-funded validator wallet ran
`genlayer staking set-identity` with both their owner and operator
accounts; both reverted with OwnableUnauthorizedAccount. The setup guide
did not say who signs, what a vesting contract changes, or that
set-identity replaces every identity field.

- Managing Your Validator: deposit, exit, claim and set-identity are
  onlyOwner on the validator wallet; examples pass --account owner, and
  the operator key can't sign them.
- set-identity replaces all nine identity fields; omitted fields are
  cleared. The example now passes several fields.
- New "If You Staked from a Vesting Contract": the vesting contract owns
  the wallet; the beneficiary signs the `genlayer vesting validator`
  commands; `validator-info` shows "Source: vesting (owner is a
  contract)"; --vesting when the lookup fails.

Checked against genlayer-cli v0.40.0-rc.5 (the npm rc tag) and
ValidatorWalletBlueprint.sol (validatorDeposit/Exit/Claim and setIdentity
are onlyOwner; setIdentity assigns the whole struct).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for genlayer-docs ready!

Name Link
🔨 Latest commit 399ff12
🔍 Latest deploy log https://app.netlify.com/projects/genlayer-docs/deploys/6ae1e24080fe0872fc6616ef
😎 Deploy Preview https://deploy-preview-770--genlayer-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f233d945-194d-48b7-b5d1-cd842da22e34
Commits

Reviewing files that changed from the base of the PR and between 1ef5092 and 399ff12.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ac1b13f2-c281-40dd-80e7-4a4e9085aba4
Commits

Reviewing files that changed from the base of the PR and between 7c3ad7c and 1ef5092.

Files selected for processing: 1
  • pages/validators/setup-guide.mdx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Changes

The validator setup guide now explains who owns and signs for standard and vesting-owned validator wallets. It also documents vesting-specific commands and states that identity updates replace all nine fields.

Validator management documentation

Layer / File(s) Summary
Wallet ownership and management instructions
pages/validators/setup-guide.mdx
The guide specifies owner signing for standard staking commands, explains that omitted identity fields are cleared, and provides management commands for vesting-owned wallets.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: jmlago

Merge Risk: Minimal · previous review 1ef50

This is a documentation-only update that explains owner and vesting-contract signing for validator operations. No merge-blocking issue was found.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title follows Conventional Commits with the docs(validators) type and scope. It names the three main changes: owner signing, vesting-owned wallets, and set-identity overwrites. All three appear in…
Description check Passed The description explains the problem: a Bradbury operator's owner and operator calls reverted with OwnableUnauthorizedAccount because the wallet was funded through vesting. It lists each documentation…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title follows Conventional Commits with the docs(validators) type and scope. It names the three main changes: owner signing, vesting-owned wallets, and set-identity overwrites. All three appear in the summary and description. The title is long at 90 characters, but it is specific and relevant.

Full details: Description check

Explanation

The description explains the problem: a Bradbury operator's owner and operator calls reverted with OwnableUnauthorizedAccount because the wallet was funded through vesting. It lists each documentation change by section. It also states what was checked against genlayer-cli v0.40.0-rc.5 and the ValidatorWalletBlueprint.sol contract. It does not follow the template's Conventional Commits guidance for the title, but the title is already in that format. The template's Description section is filled in with a detailed explanation. Closing an issue is not applicable, and no issue reference is given. The description is complete and meets the template's intent.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

dohernandez added a commit that referenced this pull request Oct 28, 2026
ubuntu-latest now resolves to Ubuntu 26.04, and Playwright 1.55 can't
install its browsers there ("Playwright does not support chromium on
ubuntu26.04-x64"), so every PR fails the E2E check at the install step
(run 40668388090 on #770, and the 2026-10-26 run). Pin the job to
ubuntu-24.04 until @playwright/test is upgraded to a release that
supports 26.04.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@dohernandez
dohernandez merged commit bb95c3c into main Oct 28, 2026
8 checks passed
@dohernandez
dohernandez deleted the docs/setup-guide-vesting-owner branch October 28, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant