Repository navigation
fix(deps): pin genlayer-js v2.0.0-rc.3 for the fee estimate fix - #436
Conversation
The CLI bundles genlayer-js, so its fee estimates only pick up SDK fixes through this pin. b629021 predates genlayer-js#242, which stops the estimate from simulation from adding execution_fee_consumed and feeReport.totalEstimatedFee (the same quantity) and so depositing about twice the execution budget per round. v2.0.0-rc.3 (3f6cf62) is the first release with that fix; it mirrors Studio v0.123.0-rc.11's recommended fee preset. Lockfile change is limited to the genlayer-js entry. Validation: npm ci, npm run build (bundle contains the corrected logic, no remaining consumed + report-total sum), vitest 840/840. Lint and tsc report the same pre-existing findings as the base branch.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem and outcome
The CLI bundles genlayer-js, so SDK fixes only reach CLI users through this pin. The current pin (
b629021) predates genlayerlabs/genlayer-js#242, which fixes the fee estimate from simulation: it addedexecution_fee_consumedandfeeReport.totalEstimatedFee(the same quantity), so deploys and writes estimated from a simulation deposited about twice the execution budget per round (188707800000000 instead of 94623000000000 on a real Studio rc.11 simulation).This pins
genlayer-jstov2.0.0-rc.3(3f6cf62), the first release with the fix, so the next CLI rc (v0.40.0-rc.6) ships it. Non-goal: no CLI code changes.Implementation and validation
package.json:github:genlayerlabs/genlayer-js#3f6cf62957fab0d53d08f283163fb176b2cb78b2(same pin style as earlier rcs).package-lock.json: only the genlayer-js entry changes (version, resolved, integrity); its dependencies are unchanged.npm ciandnpm run build: the bundle contains the corrected observed-budget logic and no remaining consumed + report-total sum.npx vitest run: 77 files, 840 tests passed.eslint srcandtsc --noEmitreport the same pre-existing findings asv0.40-dev(CI does not run them).Rollback: revert this commit to restore the previous pin.