Skip to content

fix(deps): pin genlayer-js v2.0.0-rc.3 for the fee estimate fix - #436

Merged
danieljrc888 merged 1 commit into
v0.40-devfrom
chore/bump-genlayer-js-2.0.0-rc.3
Nov 10, 2026
Merged

danieljrc888 merged 1 commit into
v0.40-devfrom
chore/bump-genlayer-js-2.0.0-rc.3

Conversation

@danieljrc888

Copy link
Copy Markdown

Problem and outcome

The CLI bundles genlayer-js, so SDK fixes only reach CLI users through this pin. The current pin (b629021) predates genlayerlabs/genlayer-js#242, which fixes the fee estimate from simulation: it added execution_fee_consumed and feeReport.totalEstimatedFee (the same quantity), so deploys and writes estimated from a simulation deposited about twice the execution budget per round (188707800000000 instead of 94623000000000 on a real Studio rc.11 simulation).

This pins genlayer-js to v2.0.0-rc.3 (3f6cf62), the first release with the fix, so the next CLI rc (v0.40.0-rc.6) ships it. Non-goal: no CLI code changes.

Implementation and validation

  • package.json: github:genlayerlabs/genlayer-js#3f6cf62957fab0d53d08f283163fb176b2cb78b2 (same pin style as earlier rcs).
  • package-lock.json: only the genlayer-js entry changes (version, resolved, integrity); its dependencies are unchanged.
  • npm ci and npm run build: the bundle contains the corrected observed-budget logic and no remaining consumed + report-total sum.
  • npx vitest run: 77 files, 840 tests passed.
  • eslint src and tsc --noEmit report the same pre-existing findings as v0.40-dev (CI does not run them).

Rollback: revert this commit to restore the previous pin.

The CLI bundles genlayer-js, so its fee estimates only pick up SDK fixes
through this pin. b629021 predates genlayer-js#242, which stops the
estimate from simulation from adding execution_fee_consumed and
feeReport.totalEstimatedFee (the same quantity) and so depositing about
twice the execution budget per round. v2.0.0-rc.3 (3f6cf62) is the
first release with that fix; it mirrors Studio v0.123.0-rc.11's
recommended fee preset.

Lockfile change is limited to the genlayer-js entry. Validation: npm ci,
npm run build (bundle contains the corrected logic, no remaining
consumed + report-total sum), vitest 840/840. Lint and tsc report the
same pre-existing findings as the base branch.
@danieljrc888 danieljrc888 self-assigned this Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b711fb2c-19ba-4ab1-8e4f-f4ab17c92c64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T15:46:14.673745Z bfaf2b7 PR opened
🔒 Security Review ✅ Completed 2026-11-10T15:49:45.474373Z bfaf2b7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danieljrc888
danieljrc888 merged commit 0c06c9a into v0.40-dev Nov 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant