Repository navigation
fix(purge): pass --hard only where sage-cachetags supports it - #14
Merged
Merged
Conversation
Most sites run sage-cachetags 1.x-2.x, whose flush has no --hard. WP-CLI rejects the unknown flag, so a hard or auto purge left cachetags unflushed. Check the command's help first and fall back to a plain flush with a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13.
cache:clear:cachetagspassed--hardfor a hard orautopurge, butflush --hardonly exists from sage-cachetags 3.2 (generoi/sage-cachetags#72, not yet tagged). The other sites with cachetags in a maintenance tier run older ones:WP-CLI rejects the unknown flag, the purge task only warns, and cachetags is left unflushed. Now the task passes
--hardonly whenwp help cachetags flushlists it. Otherwise it runs a plain flush and warns: that flush is already hard unless the site uses 2.x'sFastlySoftCacheInvalidator.Tested the check both ways: on solarplexius's installed v3.0.4 it reports no
--hard; with #72's code in wp-env it finds it.🤖 Generated with Claude Code