feat(share): --label, --no-labels, and list LABELS column - #128
Merged
Merged
Conversation
Repeatable --label replaces the set; --no-labels sends []. Omit the JSON key on refresh unless those flags were passed. New shares without --label pick up a project label from git toplevel. Directory watches forward labels over IPC. Refs gandermd/gandermd#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--labelongander share/gander watchreplaces the label set (not merge) and skips auto-label.--no-labelssendslabels: []. Watch-loopPUTstill sends content only.--labelauto-apply a project label fromgit rev-parse --show-toplevel.gander listprints aLABELScolumn (-when empty). Completions, man, README updated. Directory watches persist labels over IPC.Related Issue
Refs gandermd/gandermd#124
Pairs with gandermd/gandermd#134 (server first; this CLI 400s
--labelagainst an older gandermd).Testing
go test ./...go vet ./...Notes
Ship after the server PR is on
:latest.readJSON+DisallowUnknownFieldsrejectslabelsuntil then.