fix: preserve custom CSS in free - #3734
Open
Arukuen wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe custom CSS component now renders minified CSS through a style element. It applies saved-content class handling and passes the element through the existing filter for editor and saved content. ChangesCustom CSS rendering
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Pull request artifacts
|
|
Size Change: +148 B (+0.01%) Total Size: 2.63 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3733
Summary by CodeRabbit
Test plan
Free / Premium deactivated (main fix)
<style class="stk-custom-css">…</style>and is not stripped on savecustomCSSMinifiedor dirty the document unexpectedlyPremium still active (regression)
<style>tags for Custom CSS in editor or saved contentEdge cases
<style>tag renderedstk-custom-csscontinues to render correctly on free