Conversation
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI test step pipes
zig build testthroughtee, but the implicit Bash shell does not enablepipefail. A failed compiler or test command can therefore produce a successful step whenteesucceeds. Run 34614355939 illustrates why a green status cannot establish that the test suite passed.Select
shell: bashfor this step so GitHub Actions runs it with-eo pipefail. A failed test command now fails CI while its output is still saved totest-output.txt. The existing leak scan remains in place.Validation: parsed the workflow YAML and executed its exact test-step script using a temporary fake
zigcommand. Passing tests returned 0; a simulated compiler failure returned 37; a leak report returned 1; all three preserved the output file. The previous implicit-shell behavior returned 0 for the same simulated compiler failure.git diff --checkpassed; review found no additional error-masking pipelines in this workflow. The full Zig suite was not rerun for this workflow-only change, and this PR does not resolve the existing compiler/test failures or missingauthor-guardstep.Related to #616 and #810.