Skip to content

fix: avoid cfn-lint W1030 on TaskRoleArn when TaskRole is unset #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
credfeto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid cfn-lint W1030 on TaskRoleArn when TaskRole is unset #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ad6062
fix: avoid cfn-lint W1030 on TaskRoleArn when TaskRole is unset
credfeto Sep 3, 2026
6061b42
docs: add changelog entry for cfn-lint W1030 fix
credfeto Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
- Guard against IndexOutOfRangeException when Branches list is empty in GithubStatusNotificationHandler
- Fixed CS0433 ambiguous xunit type conflict in test projects caused by FunFair.Test.Common now depending on the AOT-flavoured xunit v3 packages, by switching test projects to the matching xunit.v3.aot.mtp-v2 runner package
- Added missing IncludeAssets on NuGet package references required by FunFair.BuildCheck
- Resolved cfn-lint W1030 warning on the TaskRoleArn CloudFormation property by only setting it when a TaskRole is provided
### Changed
- Dependencies - Updated NSubstitute.Analyzers.CSharp to 1.0.17
- Switched to use minimal APIs
Expand Down
24 changes: 23 additions & 1 deletion cloudformation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,20 @@
"Default": "arn:aws:secretsmanager:eu-west-1:117769150821:secret:BuildBot-ph1YIJ"
}
},
"Conditions": {
"HasTaskRole": {
"Fn::Not": [
{
"Fn::Equals": [
{
"Ref": "TaskRole"
},
""
]
}
]
}
},
"Metadata": {
"Application": {
"Ref": "ApplicationName"
Expand Down Expand Up @@ -279,7 +293,15 @@
"Ref": "TaskExecutionRole"
},
"TaskRoleArn": {
"Ref": "TaskRole"
"Fn::If": [
"HasTaskRole",
{
"Ref": "TaskRole"
},
{
"Ref": "AWS::NoValue"
}
]
},
"RequiresCompatibilities": ["FARGATE"],
"NetworkMode": "awsvpc",
Expand Down
Loading