fix: update site-build workflow for website/ → docs/ move

[maruiz93]

Summary

• Update paths in the "Build Doc Site" workflow to reflect fullsend's website/ → docs/ reorganization (commit 8f3a4363)
• Bump actions/checkout to v7.0.1 and actions/setup-node to v6.5.0 to match fullsend repo
• Add comments explaining the cross-repo symlink and why npx vitepress build docs is used instead of npm run docs:build

Test plan

• "Build Doc Site" check passes on this PR (setup-node cache resolves, npm ci succeeds, vitepress build completes)

Closes #50

🤖 Generated with Claude Code

[qodo-code-review]

PR Summary by Qodo

Fix doc-site build workflow after fullsend website/ → docs/ reorg

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

AI Description

• Update Build Doc Site workflow paths for fullsend’s website/ → docs/ move.
• Align pinned GitHub Actions versions with upstream fullsend workflow.
• Preserve experiments content injection via symlink and build with VitePress directly.

Diagram

graph TD
  W["site-build.yml"] --> E[("experiments checkout")] --> F[("fullsend checkout")] --> N["setup-node + npm cache"] --> I["npm ci"] --> S["symlink docs/experiments"] --> B["vitepress build docs"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Run `npm run docs:build` and configure submodule auth

• ➕ Keeps build invocation aligned with fullsend’s intended scripts
• ➕ Avoids relying on VitePress CLI behavior staying stable
• ➖ Requires SSH keys or token-based auth for submodule update in CI
• ➖ Higher maintenance and greater risk of intermittent CI failures

2. Copy experiments content into docs/ instead of symlinking

• ➕ Avoids symlink edge-cases on some runners/tools
• ➕ More explicit, less dependent on filesystem link semantics
• ➖ Extra build step and potentially slower CI
• ➖ Risk of stale content if copy step misses paths or exclusions

Recommendation: Keep the current approach: adjust paths for the docs/ move, replace the experiments submodule with a symlink, and run npx vitepress build docs directly. It minimizes CI secrets/auth complexity while preserving the cross-repo “combined site” build behavior.

Files changed (1) +12 / -9

Other (1) +12 / -9

site-build.ymlFix doc-site build workflow paths and VitePress build invocation +12/-9

Fix doc-site build workflow paths and VitePress build invocation

• Updates the workflow to install/build from the fullsend repo root after the VitePress site moved from website/ to docs/. Adjusts npm cache dependency path to the root package-lock.json, refreshes pinned checkout/setup-node action SHAs, and replaces the previous submodule/symlink steps with a single docs/experiments symlink plus a direct 'vitepress build docs' call to avoid submodule updates.

.github/workflows/site-build.yml

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 12:13 PM UTC · Completed 12:24 PM UTC

Commit: ffb7906 · View workflow run →

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[fullsend-ai-review]

Review

Findings

Medium

• [protected-path] .github/workflows/site-build.yml — This PR modifies a file under the protected .github/ path. The linked issue (Build Doc Site workflow broken since fullsend moved website/ to docs/ #50) provides clear context for why the workflow file needs updating (fullsend's website/ → docs/ reorganization broke the build), and the changes are well-scoped to the reported problem. Human approval is always required for protected-path changes, regardless of context.

Low

• [scope-creep] .github/workflows/site-build.yml:20 — Dependency version bumps (actions/checkout v7.0.0→v7.0.1, actions/setup-node v6.4.0→v6.5.0) are not explicitly authorized by issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50. The issue authorizes fixing the broken workflow by updating paths, not bumping action versions. The PR body acknowledges these bumps are to "match fullsend repo" which is a separate maintenance concern.
  Remediation: Remove the dependency version bumps from this PR and submit them separately, or update issue Build Doc Site workflow broken since fullsend moved website/ to docs/ #50 to explicitly authorize bumping dependencies.

---

Labels: PR fixes a broken CI workflow (.github/workflows/) under protected paths

[fullsend-ai-review]

See the review comment for full details.

[fullsend-ai-review]

[low] scope-creep

Dependency version bumps (actions/checkout v7.0.0 to v7.0.1, actions/setup-node v6.4.0 to v6.5.0) are not explicitly authorized by issue #50. The issue authorizes fixing the broken workflow by updating paths, not bumping action versions. The PR body acknowledges these bumps are to match fullsend repo which is a separate maintenance concern.

Suggested fix: Remove the dependency version bumps from this PR and submit them separately, or update issue #50 to explicitly authorize bumping dependencies.