Resolve Dependabot security alerts for tests/fable dependencies - #267
Merged
Conversation
Co-authored-by: gdziadkiewicz <8547855+gdziadkiewicz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Dependabot security alerts for test-only JavaScript/Fable project
Resolve Dependabot security alerts for tests/fable dependencies
Sep 6, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency bump and regenerated lockfile are internally consistent (Mocha 12 and patched transitive versions) and no functional code changes were introduced beyond the test tooling update.
Pull request overview
This PR updates the test-only JavaScript/Fable tooling under tests/fable to address Dependabot-reported security advisories by upgrading Mocha and regenerating the Yarn v1 lockfile to pull in patched transitive dependencies.
Changes:
- Upgraded
mochadevDependency from^11.7.5to^12.0.0. - Regenerated
tests/fable/yarn.lock, updating vulnerable transitive packages (notablydiff,serialize-javascript,brace-expansion, andjs-yaml) to patched versions.
File summaries
| File | Description |
|---|---|
| tests/fable/package.json | Bumps Mocha to v12 to resolve security alerts in the test runner toolchain. |
| tests/fable/yarn.lock | Updates lockfile to patched transitive dependency versions aligned with the Mocha bump and vulnerability remediation. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gdziadkiewicz
marked this pull request as ready for review
September 6, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot security alerts were open against transitive dependencies in the test-only JavaScript/Fable suite under
tests/fable. This change resolves all open vulnerabilities by updating the test runner dependency and lockfile while preserving existing test execution.Dependency Updates
mocha: Upgraded direct devDependency from^11.7.5to^12.0.0intests/fable/package.json.yarn.lock: Regenerated lockfile to pick up patched transitive dependencies, resolving all open advisories:diff(updated to9.0.0): fixes DoS inparsePatch/applyPatch(GHSA-m8v8-pxw8-6h4r).serialize-javascript(updated to7.1.1): fixes RCE (GHSA-76p3-8jx3-jpfq) and DoS (GHSA-4g9c-4jjf-95p9).brace-expansion(updated to5.0.9): fixes memory exhaustion / DoS (GHSA-mh99-v99m-4gvg, GHSA-v6vv-v655-v544, CVE-2026-13149, CVE-2026-14257).js-yaml(updated to5.4.1): fixes quadratic complexity in!!omapresolution (GHSA-m559-m5pm-2686, CVE-2026-59870).Verification
yarn auditintests/fablenow reports 0 vulnerabilities across all audited packages.