[repo-assist] Tests: add coverage for distinctUntilChanged, takeWhile, skipWhile - #343
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
These sync-predicate/default-equality variants had no direct tests (only their Async or custom-comparer counterparts were covered). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds direct test coverage for three public API functions that previously lacked tests of their own:
AsyncSeq.distinctUntilChanged— only itsWithAsync/With(custom equality) counterparts andAsyncSeq.distinctwere tested; the default-equality variant itself was never exercised directly.AsyncSeq.takeWhile— onlytakeWhileAsyncandtakeWhileInclusivehad tests.AsyncSeq.skipWhile— onlyskipWhileAsynchad a test.No functional/source changes — test-only PR, following the style of neighboring existing tests (
EQhelper fortakeWhile/skipWhile,toListSynchronouslyfordistinctUntilChanged).Test Status
dotnet build FSharp.Control.AsyncSeq.sln -c Release— succeeded, 0 errors.dotnet test tests/FSharp.Control.AsyncSeq.Tests -c Release— 491/491 tests passed (486 pre-existing + 5 new).🤖 This PR was created by Repo Assist, an automated AI assistant, as a testing-improvement fallback for Task 5 (no clearly beneficial low-risk coding improvement was identified this run). A human maintainer should review before merging.
Add this agentic workflow to your repo
To install this agentic workflow, run