display: add Pinball 2000 video output support - #573
Merged
Conversation
Greptile SummaryThe PR adds a distinct RGB video frame format and routes it through the existing display-texture path while exposing material render-state overrides for overlay composition.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| VisualPinball.Unity/VisualPinball.Unity/Game/Engine/IGamelogicEngine.cs | Appends Video24 without changing the numeric values of existing frame formats. |
| VisualPinball.Unity/VisualPinball.Unity/Display/DotMatrixDisplayComponent.cs | Processes Video24 through the established RGB24 texture-upload path and correctly treats it as palette-free. |
| VisualPinball.Unity/Assets/Shaders/Builtin/DotMatrixDisplayShader.shader | Makes blend factors and depth writes material-configurable while preserving the previous opaque defaults. |
| VisualPinball.Unity/Assets/Shaders/Srp/Display/DotMatrixDisplayGraph.shadergraph | Enables per-material overrides for the SRP display shader. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Game logic engine] -->|Video24 RGB frame| B[DotMatrixDisplayComponent]
B --> C[RGB24 texture upload]
C --> D[Display material]
D --> E[Built-in or SRP display shader]
E --> F[Composited video output]
Reviews (2): Last reviewed commit: "display: add Pinball 2000 video output s..." | Re-trigger Greptile
freezy
force-pushed
the
feat/pinball-2000-display-output
branch
from
August 15, 2026 20:30
ba91f88 to
23d2a8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Video24RGB frame format for Pinball 2000 video outputVideo24frames through the existing display texture pathValidation
git diff --checkFollow-up
The PinMAME-specific producer and CRT presentation live in the companion PinMAME integration package.