Skip to content

display: add Pinball 2000 video output support - #573

Merged
freezy merged 1 commit into
masterfrom
feat/pinball-2000-display-output
Aug 15, 2026
Merged

display: add Pinball 2000 video output support#573
freezy merged 1 commit into
masterfrom
feat/pinball-2000-display-output

Conversation

@freezy

@freezy freezy commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a distinct Video24 RGB frame format for Pinball 2000 video output
  • render Video24 frames through the existing display texture path
  • allow per-material blend and depth overrides so the video display can be composed as an overlay

Validation

  • git diff --check
  • verified the commit contains only the four intended VPE display/interface files

Follow-up

The PinMAME-specific producer and CRT presentation live in the companion PinMAME integration package.

@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds a distinct RGB video frame format and routes it through the existing display-texture path while exposing material render-state overrides for overlay composition.

  • Adds Video24 to the game-logic display interface.
  • Handles Video24 frames as 24-bit RGB textures.
  • Enables configurable blending and depth writes in the built-in and SRP display shaders.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
VisualPinball.Unity/VisualPinball.Unity/Game/Engine/IGamelogicEngine.cs Appends Video24 without changing the numeric values of existing frame formats.
VisualPinball.Unity/VisualPinball.Unity/Display/DotMatrixDisplayComponent.cs Processes Video24 through the established RGB24 texture-upload path and correctly treats it as palette-free.
VisualPinball.Unity/Assets/Shaders/Builtin/DotMatrixDisplayShader.shader Makes blend factors and depth writes material-configurable while preserving the previous opaque defaults.
VisualPinball.Unity/Assets/Shaders/Srp/Display/DotMatrixDisplayGraph.shadergraph Enables per-material overrides for the SRP display shader.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Game logic engine] -->|Video24 RGB frame| B[DotMatrixDisplayComponent]
    B --> C[RGB24 texture upload]
    C --> D[Display material]
    D --> E[Built-in or SRP display shader]
    E --> F[Composited video output]
Loading

Reviews (2): Last reviewed commit: "display: add Pinball 2000 video output s..." | Re-trigger Greptile

@freezy
freezy force-pushed the feat/pinball-2000-display-output branch from ba91f88 to 23d2a8a Compare August 15, 2026 20:30
@freezy
freezy merged commit 6c92d02 into master Aug 15, 2026
15 checks passed
@freezy
freezy deleted the feat/pinball-2000-display-output branch August 15, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant