Skip to content

editor: remove legacy VPX patcher - #572

Merged
freezy merged 1 commit into
masterfrom
feat/remove-vpx-patcher
Aug 15, 2026
Merged

editor: remove legacy VPX patcher#572
freezy merged 1 commit into
masterfrom
feat/remove-vpx-patcher

Conversation

@freezy

@freezy freezy commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the legacy table-specific VPX patcher project and import option
  • remove patcher-only material adapter APIs and dead import APIs
  • remove obsolete patcher documentation and solution references

Validation

  • reviewed by Opus with no blocking findings
  • verified no stale tracked patcher references remain
  • verified the staged diff contains no line-ending churn

@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown

Greptile Summary

The PR removes the legacy table-specific VPX patcher and its integration with table imports and render-pipeline material adapters.

  • Deletes the patcher assembly, table patches, matcher infrastructure, and associated project metadata.
  • Removes patcher options and calls from the VPX import pipeline.
  • Removes patcher-only material-adapter APIs.
  • Updates solution files, documentation, ignore rules, and the changelog to reflect the removal.

Confidence Score: 5/5

The PR appears safe to merge, with the legacy patcher and its repository references removed consistently.

All remaining repository callers and project references align with the simplified import and rendering APIs, and no concrete blocking or non-blocking defect remains.

Important Files Changed

Filename Overview
VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxSceneConverter.cs Removes patcher initialization, per-item patch execution, post-patching, and the applyPatch conversion option while retaining the normal import lifecycle.
VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxImportEngine.cs Removes applyPatch and obsolete filename plumbing from public import overloads and consistently invokes the simplified converter API.
VisualPinball.Unity/VisualPinball.Unity.Editor/Rendering/RenderPipelineConverter.cs Removes the patcher-only material-adapter contract from render-pipeline implementations.
VisualPinball.Unity/VisualPinball.Engine.Unity.sln Removes the deleted patcher project and all of its build configurations from the solution.
VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxImportWizard.cs Removes the patch toggle and updates imports to use named arguments with the simplified API.

Reviews (1): Last reviewed commit: "editor: remove legacy VPX patcher" | Re-trigger Greptile

@freezy
freezy merged commit 3fbf42e into master Aug 15, 2026
15 checks passed
@freezy
freezy deleted the feat/remove-vpx-patcher branch August 15, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant