editor: remove legacy VPX patcher - #572
Merged
Merged
Conversation
Greptile SummaryThe PR removes the legacy table-specific VPX patcher and its integration with table imports and render-pipeline material adapters.
Confidence Score: 5/5The PR appears safe to merge, with the legacy patcher and its repository references removed consistently. All remaining repository callers and project references align with the simplified import and rendering APIs, and no concrete blocking or non-blocking defect remains.
|
| Filename | Overview |
|---|---|
| VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxSceneConverter.cs | Removes patcher initialization, per-item patch execution, post-patching, and the applyPatch conversion option while retaining the normal import lifecycle. |
| VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxImportEngine.cs | Removes applyPatch and obsolete filename plumbing from public import overloads and consistently invokes the simplified converter API. |
| VisualPinball.Unity/VisualPinball.Unity.Editor/Rendering/RenderPipelineConverter.cs | Removes the patcher-only material-adapter contract from render-pipeline implementations. |
| VisualPinball.Unity/VisualPinball.Engine.Unity.sln | Removes the deleted patcher project and all of its build configurations from the solution. |
| VisualPinball.Unity/VisualPinball.Unity.Editor/Import/VpxImportWizard.cs | Removes the patch toggle and updates imports to use named arguments with the simplified API. |
Reviews (1): Last reviewed commit: "editor: remove legacy VPX patcher" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation