Skip to content

fix(ci): repair full validation tests and runner configuration - #319

Merged
jcwal1516 merged 1 commit into
mainfrom
fix/full-validation-gates
Nov 2, 2026
Merged

jcwal1516 merged 1 commit into
mainfrom
fix/full-validation-gates

Conversation

@jcwal1516

@jcwal1516 jcwal1516 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Full validation exposed three gaps: native tests did not compile without default features, the spelling checker treated guard digests as words, and a Linux test runner exhausted its disk.

  • Make the capacity-error helper and packet counters available to all test builds. Count parsed headers in reduced-feature tests too, preserving the packet-selection assertions.
  • Ignore only the ok: field followed by a 16-digit hexadecimal digest. Baseline prose remains checked, and ordinary misspellings still fail.
  • Omit debug symbols from the full test matrix and use a separate cache for that configuration to reduce hosted-runner disk use. Test coverage and debug assertions are unchanged.

Validation: reproduced the three reduced-feature compile errors, then passed the existing packet-selection regression and the affected native Miri step (8 tests, installed nightly-2026-08-13). Both baseline files pass the spelling check; a control confirms text outside the digest remains checked. The 55 CI-planner/verifier tests, native library/test Clippy, formatting, whitespace checks and workflow YAML parsing pass. The post-merge Full validation run passed, including Miri on the CI nightly, the spelling check, every test-matrix lane, and the final aggregate.

The shared native files with prior jcoyne contributions are crates/j2k-native/src/j2c/mod.rs, crates/j2k-native/src/j2c/decode.rs and crates/j2k-native/src/j2c/segment.rs. Their changes are test configuration and counters; the #133 ring depths, error replay, band release and executor design remain unchanged.

The original failing run is Full validation. Exact-head CUDA and Metal quick validation passed.

@jcwal1516
jcwal1516 merged commit 968dbb4 into main Nov 2, 2026
30 of 32 checks passed
@jcwal1516
jcwal1516 deleted the fix/full-validation-gates branch November 2, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant