Repository navigation
fix(j2k): classify GPU Tier-1 decode failures - #315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU Tier-1 FAIL statuses were reported through generic runtime-error classifications. Add a Decode class so callers can distinguish decode execution failures while retaining the backend diagnostics.
AdapterErrorKind::DecodeandBackendErrorKind::Decodeto existing non-exhaustive enums, preserving existing discriminants, and addBackendError::decode.Error::Decode(J2kError::Backend)wrapper. Their display now starts withbackend failed (decode):; coding path, status, detail and batch source index remain in the diagnostic.CudaTier1JobFailedwhose direct source is a bareKernelJobStatuswith FAIL code 1. Typed source and job attribution are preserved. Unsupported or unknown statuses, raw runtime failures and combined cleanup/release failures retain their existing classifications.The ordinary API inventory adds exactly three items. The 0.13.2 API report and review are updated against published 0.13.1; no new Metal error variant or CodecError method is introduced.
Validation: focused facade error tests, Metal error/status tests, and CUDA error tests with
cuda-runtimeboth disabled and enabled; formatting, strict and workspace clippy, repository lint, and the full semver check pass. Tests cover the selected FAIL statuses, source attribution and the runtime/unsupported/cleanup exclusions.CUDA and Metal quick validation passed on this PR head.