🛡️ Sentinel: [HIGH] Fix missing serialization sinks in taint propagation - #175
🛡️ Sentinel: [HIGH] Fix missing serialization sinks in taint propagation#175tachyon-beep wants to merge 2 commits into
Conversation
Added `shelve.open`, `dill.load`, `dill.loads`, `jsonpickle.decode`, `joblib.load`, and `torch.load` to `_SERIALISATION_SINKS` in `src/wardline/scanner/taint/variable_level.py`. This ensures that validation provenance is properly shed and outputs from these deserialization calls are treated as UNKNOWN_RAW, preventing false negatives in static analysis. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bec14e3d87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "tomllib.load", | ||
| "tomli_w.dumps", | ||
| "tomli_w.dump", | ||
| "shelve.open", |
There was a problem hiding this comment.
When shelve.open(..., flag="n") is used, the underlying database is always created empty rather than opened for reading existing serialized data. Classifying every shelve.open result as UNKNOWN_RAW therefore taints a fresh shelf and all subsequent reads even when the program stores only clean values, producing false trusted-return or downstream-sink findings. Handle the literal fresh-create mode separately instead of applying this unconditional entry.
Useful? React with 👍 / 👎.
Added `shelve.open`, `dill.load`, `dill.loads`, `jsonpickle.decode`, `joblib.load`, and `torch.load` to `_SERIALISATION_SINKS` in `src/wardline/scanner/taint/variable_level.py`. This ensures that validation provenance is properly shed and outputs from these deserialization calls are treated as UNKNOWN_RAW, preventing false negatives in static analysis. Also includes standard ruff formatting on the codebase to satisfy the format checker which broke in CI due to existing unformatted files. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
1 participant
🚨 Severity: HIGH
💡 Vulnerability:
dill.load,jsonpickle.decode,shelve.open,joblib.load, andtorch.loadwere missing from_SERIALISATION_SINKS, which could lead to false negatives where untrusted data flows into these dangerous deserialization functions without losing its validation provenance.🎯 Impact: If exploited, these false negatives could allow critical remote code execution vulnerabilities to slip through static analysis without alerting developers.
🔧 Fix: Added
"shelve.open","dill.load","dill.loads","jsonpickle.decode","joblib.load", and"torch.load"to_SERIALISATION_SINKSinsrc/wardline/scanner/taint/variable_level.pyto ensure proper taint shedding.✅ Verification: Run
uv run pytestto ensure all tests pass and ensure no regressions.PR created automatically by Jules for task 14853706601299534012 started by @tachyon-beep